linux-kernel - Re: [PATCH 01/10] dt-bindings: ASoC: Document Tegra264 APE support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <d978a394-40c0-442c-82b5-58abfaa19f64@kernel.org>
Date: Thu, 24 Apr 2025 10:50:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Sheetal ." <sheetal@...dia.com>, broonie@...nel.org,
 linux-sound@...r.kernel.org
Cc: linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
 jonathanh@...dia.com, thierry.reding@...il.com, mkumard@...dia.com,
 spujar@...dia.com
Subject: Re: [PATCH 01/10] dt-bindings: ASoC: Document Tegra264 APE support

On 24/04/2025 09:12, Sheetal . wrote:
> 
> On 23-04-2025 18:16, Krzysztof Kozlowski wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 22/04/2025 09:27, Sheetal . wrote:
>>> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml
>>> index b4bee466d67a..ee33f056b125 100644
>>> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml
>>> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml
>>> @@ -21,6 +21,7 @@ allOf:
>>>   properties:
>>>     compatible:
>>>       enum:
>>> +      - nvidia,tegra264-audio-graph-card
>>>         - nvidia,tegra210-audio-graph-card
>>>         - nvidia,tegra186-audio-graph-card
>>>
>>> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-asrc.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-asrc.yaml
>>> index e15f387c4c29..26e1ed7ec7a7 100644
>>> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra186-asrc.yaml
>>> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-asrc.yaml
>>> @@ -31,7 +31,9 @@ properties:
>>>
>>>     compatible:
>>>       oneOf:
>>> -      - const: nvidia,tegra186-asrc
>>> +      - enum:
>>> +          - nvidia,tegra264-asrc
>>> +          - nvidia,tegra186-asrc
>> Keep proper order, not random, not reversed.
>>
>> <form letter>
>> Please use scripts/get_maintainers.pl to get a list of necessary people
>> and lists to CC. It might happen, that command when run on an older
>> kernel, gives you outdated entries. Therefore please be sure you base
>> your patches on recent Linux kernel.
>>
>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
>> people, so fix your workflow. Tools might also fail if you work on some
>> ancient tree (don't, instead use mainline) or work on fork of kernel
>> (don't, instead use mainline). Just use b4 and everything should be
>> fine, although remember about `b4 prep --auto-to-cc` if you added new
>> patches to the patchset.
>>
>> You missed at least devicetree list (maybe more), so this won't be
>> tested by automated tooling. Performing review on untested code might be
>> a waste of time.
>>
>> Please kindly resend and include all necessary To/Cc entries.
>> </form letter>
> 
> 
> I realized after sending the original series that I had missed the DT 
> reviewers and already re-sent the complete series including the DT 
> reviewers, with the subject prefix |*"RESEND PATCH"*|. Please review 
> that version and ignore this one. Apologies for the inconvenience.
No, you got review here, so implement the feedback.


Best regards,
Krzysztof