linux-kernel - Re: [PATCH] ocfs2: remove unnecessary NULL check before unregister_sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65f0265e-bcc4-48a5-9e8b-cc3aab13dde0@linux.alibaba.com>
Date: Thu, 24 Apr 2025 08:57:42 +0800
From: Joseph Qi <joseph.qi@...ux.alibaba.com>
To: Chen Ni <nichen@...as.ac.cn>, mark@...heh.com, jlbec@...lplan.org,
 akpm <akpm@...ux-foundation.org>
Cc: ocfs2-devel@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ocfs2: remove unnecessary NULL check before
 unregister_sysctl_table()



On 2025/4/22 15:30, Chen Ni wrote:
> unregister_sysctl_table() checks for NULL pointers internally.
> Remove unneeded NULL check here.
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>

Reviewed-by: Joseph Qi <joseph.qi@...ux.alibaba.com>
> ---
>  fs/ocfs2/stackglue.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c
> index ddd761cf44c8..a28c127b9934 100644
> --- a/fs/ocfs2/stackglue.c
> +++ b/fs/ocfs2/stackglue.c
> @@ -691,8 +691,7 @@ static void __exit ocfs2_stack_glue_exit(void)
>  	memset(&locking_max_version, 0,
>  	       sizeof(struct ocfs2_protocol_version));
>  	ocfs2_sysfs_exit();
> -	if (ocfs2_table_header)
> -		unregister_sysctl_table(ocfs2_table_header);
> +	unregister_sysctl_table(ocfs2_table_header);
>  }
>  
>  MODULE_AUTHOR("Oracle");