linux-kernel - Re: [PATCH] kexec: include asm/early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <19985176-a552-482e-9baf-7a1c4fe45d89@app.fastmail.com>
Date: Thu, 24 Apr 2025 11:33:58 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Simon Horman" <horms@...nel.org>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Alexander Graf" <graf@...zon.com>, "Mike Rapoport" <rppt@...nel.org>,
 "Changyuan Lyu" <changyuanl@...gle.com>,
 "Andrew Morton" <akpm@...ux-foundation.org>, "Baoquan He" <bhe@...hat.com>,
 kexec@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kexec: include asm/early_ioremap.h

On Thu, Apr 24, 2025, at 11:23, Simon Horman wrote:
> On Wed, Apr 23, 2025 at 06:29:18PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> The early_memremap() function is decleared in a header that is only indirectly
>> included here:
>> 
>> kernel/kexec_handover.c:1116:8: error: call to undeclared function 'early_memremap'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>>  1116 |         fdt = early_memremap(fdt_phys, fdt_len);
>>       |               ^
>> 
>> Fixes: 4bfe738ce89a ("kexec: add KHO support to kexec file loads")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> I didn't try to reproduce this problem. And perhaps this isn't particularly
> important. But, naively, I would have expected the following as it is
> the commit the introduces calls to early_memremap() in exec_handover.c.
>
> Fixes: b0a311dba688 ("kexec: add KHO parsing support")

Yes, you are correct. I've sent a v2 now. Ideally Andrew can just fold
the fixup into the "kexec: add KHO parsing support" patch, in which
case my incorrect changelog text disappears.

    Arnd