linux-kernel - Re: [PATCH v7 04/10] dt-bindings: clock: Add Qualcomm QCS615 Display clock controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8586e84c-4a2c-4aca-831a-6fde0cd39a45@quicinc.com>
Date: Thu, 24 Apr 2025 15:05:11 +0530
From: Taniya Das <quic_tdas@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        "Stephen
 Boyd" <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Catalin Marinas
	<catalin.marinas@....com>,
        Will Deacon <will@...nel.org>
CC: Ajit Pandey <quic_ajipan@...cinc.com>,
        Imran Shaik
	<quic_imrashai@...cinc.com>,
        Jagadeesh Kona <quic_jkona@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v7 04/10] dt-bindings: clock: Add Qualcomm QCS615 Display
 clock controller



On 4/15/2025 10:55 AM, Krzysztof Kozlowski wrote:
> On 14/04/2025 10:42, Taniya Das wrote:
>> +
>> +required:
>> +  - compatible
>> +  - reg
> 
> Drop
> 
>> +  - clocks
>> +  - '#clock-cells'
> 
> Drop
> 
>> +  - '#reset-cells'
> 
> Drop
> 
> Please look at other bindings when writing yours.

Unfortunately I picked the wrong example. But fixed it in the next patch.

> 
>> +  - '#power-domain-cells'
>> +
>> +allOf:
>> +  - $ref: qcom,gcc.yaml#
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/clock/qcom,rpmh.h>
>> +    #include <dt-bindings/clock/qcom,qcs615-gcc.h>
>> +    clock-controller@...0000 {
>> +      compatible = "qcom,qcs615-dispcc";
>> +      reg = <0x0af00000 0x20000>;
>> +      clocks = <&rpmhcc RPMH_CXO_CLK>,
>> +               <&gcc GCC_DISP_GPLL0_DIV_CLK_SRC>,
>> +               <&mdss_dsi0_phy 0>,
>> +               <&mdss_dsi0_phy 1>,
>> +               <&mdss_dsi1_phy 0>,
>> +               <&mdss_dp_phy   0>,
>> +               <&mdss_dp_vco   0>;
> 
> 
> Drop excessive spaces before '0'.
> 
Fixed in the latest patch.
> 
> Best regards,
> Krzysztof
>