linux-kernel - Re: [PATCH v13 20/28] riscv/hwprobe: zicfilp / zicfiss enumeration in hwprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <680a0cd4.050a0220.296475.3867@mx.google.com>
Date: Thu, 24 Apr 2025 12:05:04 +0200
From: Miquel Sabaté Solà <mikisabate@...il.com>
To: Deepak Gupta <debug@...osinc.com>
Cc: Thomas Gleixner <tglx@...utronix.de>,  Ingo Molnar <mingo@...hat.com>,
  Borislav Petkov <bp@...en8.de>,  Dave Hansen
 <dave.hansen@...ux.intel.com>,  x86@...nel.org,  "H. Peter Anvin"
 <hpa@...or.com>,  Andrew Morton <akpm@...ux-foundation.org>,  "Liam R.
 Howlett" <Liam.Howlett@...cle.com>,  Vlastimil Babka <vbabka@...e.cz>,
  Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,  Paul Walmsley
 <paul.walmsley@...ive.com>,  Palmer Dabbelt <palmer@...belt.com>,  Albert
 Ou <aou@...s.berkeley.edu>,  Conor Dooley <conor@...nel.org>,  Rob Herring
 <robh@...nel.org>,  Krzysztof Kozlowski <krzk+dt@...nel.org>,  Arnd
 Bergmann <arnd@...db.de>,  Christian Brauner <brauner@...nel.org>,  Peter
 Zijlstra <peterz@...radead.org>,  Oleg Nesterov <oleg@...hat.com>,  Eric
 Biederman <ebiederm@...ssion.com>,  Kees Cook <kees@...nel.org>,  Jonathan
 Corbet <corbet@....net>,  Shuah Khan <shuah@...nel.org>,  Jann Horn
 <jannh@...gle.com>,  Conor Dooley <conor+dt@...nel.org>,  Miguel Ojeda
 <ojeda@...nel.org>,  Alex Gaynor <alex.gaynor@...il.com>,  Boqun Feng
 <boqun.feng@...il.com>,  Gary Guo <gary@...yguo.net>,  Björn Roy Baron
 <bjorn3_gh@...tonmail.com>,  Benno Lossin <benno.lossin@...ton.me>,
  Andreas Hindborg <a.hindborg@...nel.org>,  Alice Ryhl
 <aliceryhl@...gle.com>,  Trevor Gross <tmgross@...ch.edu>,
  linux-kernel@...r.kernel.org,  linux-fsdevel@...r.kernel.org,
  linux-mm@...ck.org,  linux-riscv@...ts.infradead.org,
  devicetree@...r.kernel.org,  linux-arch@...r.kernel.org,
  linux-doc@...r.kernel.org,  linux-kselftest@...r.kernel.org,
  alistair.francis@....com,  richard.henderson@...aro.org,
  jim.shu@...ive.com,  andybnac@...il.com,  kito.cheng@...ive.com,
  charlie@...osinc.com,  atishp@...osinc.com,  evan@...osinc.com,
  cleger@...osinc.com,  alexghiti@...osinc.com,  samitolvanen@...gle.com,
  broonie@...nel.org,  rick.p.edgecombe@...el.com,
  rust-for-linux@...r.kernel.org,  Zong Li <zong.li@...ive.com>
Subject: Re: [PATCH v13 20/28] riscv/hwprobe: zicfilp / zicfiss enumeration
 in hwprobe

On dj., d’abr. 24 2025, Deepak Gupta wrote:

Hello,

> Adding enumeration of zicfilp and zicfiss extensions in hwprobe syscall.
>
> Reviewed-by: Zong Li <zong.li@...ive.com>
> Signed-off-by: Deepak Gupta <debug@...osinc.com>
> ---
>  arch/riscv/include/uapi/asm/hwprobe.h | 2 ++
>  arch/riscv/kernel/sys_hwprobe.c       | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/arch/riscv/include/uapi/asm/hwprobe.h b/arch/riscv/include/uapi/asm/hwprobe.h
> index c3c1cc951cb9..c1b537b50158 100644
> --- a/arch/riscv/include/uapi/asm/hwprobe.h
> +++ b/arch/riscv/include/uapi/asm/hwprobe.h
> @@ -73,6 +73,8 @@ struct riscv_hwprobe {
>  #define		RISCV_HWPROBE_EXT_ZCMOP		(1ULL << 47)
>  #define		RISCV_HWPROBE_EXT_ZAWRS		(1ULL << 48)
>  #define		RISCV_HWPROBE_EXT_SUPM		(1ULL << 49)
> +#define		RISCV_HWPROBE_EXT_ZICFILP	(1ULL << 50)
> +#define		RISCV_HWPROBE_EXT_ZICFISS	(1ULL << 51)

Notice that, as it stands in Linux v6.15-rc, this will conflict with the
values for Zicntr and Zihpm. See 4458b8f68dc7 ("riscv: hwprobe: export
Zicntr and Zihpm extensions"). I'd say that you should update these
values.

>  #define RISCV_HWPROBE_KEY_CPUPERF_0	5
>  #define		RISCV_HWPROBE_MISALIGNED_UNKNOWN	(0 << 0)
>  #define		RISCV_HWPROBE_MISALIGNED_EMULATED	(1 << 0)
> diff --git a/arch/riscv/kernel/sys_hwprobe.c b/arch/riscv/kernel/sys_hwprobe.c
> index bcd3b816306c..d802ff707913 100644
> --- a/arch/riscv/kernel/sys_hwprobe.c
> +++ b/arch/riscv/kernel/sys_hwprobe.c
> @@ -108,6 +108,8 @@ static void hwprobe_isa_ext0(struct riscv_hwprobe *pair,
>  		EXT_KEY(ZCB);
>  		EXT_KEY(ZCMOP);
>  		EXT_KEY(ZICBOZ);
> +		EXT_KEY(ZICFILP);
> +		EXT_KEY(ZICFISS);
>  		EXT_KEY(ZICOND);
>  		EXT_KEY(ZIHINTNTL);
>  		EXT_KEY(ZIHINTPAUSE);

Greetings,
Miquel

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)