linux-kernel - Re: [PATCH 06/12] pinctrl: ingenic: use new GPIO line value setter callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fff5e22cd0cc75f1007bbe43889f97554efa6316.camel@crapouillou.net>
Date: Thu, 24 Apr 2025 12:13:59 +0200
From: Paul Cercueil <paul@...pouillou.net>
To: Bartosz Golaszewski <brgl@...ev.pl>, Basavaraj Natikar	
 <Basavaraj.Natikar@....com>, Shyam Sundar S K <Shyam-sundar.S-k@....com>, 
 Linus Walleij <linus.walleij@...aro.org>, Chen-Yu Tsai <wens@...e.org>,
 Maxime Coquelin	 <mcoquelin.stm32@...il.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>,  Andreas Färber	
 <afaerber@...e.de>, Manivannan Sadhasivam
 <manivannan.sadhasivam@...aro.org>,  Steen Hegelund
 <Steen.Hegelund@...rochip.com>, Daniel Machon
 <daniel.machon@...rochip.com>, 	UNGLinuxDriver@...rochip.com, Ludovic
 Desroches <ludovic.desroches@...rochip.com>,  Nicolas Ferre
 <nicolas.ferre@...rochip.com>, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
 Andrew Lunn <andrew@...n.ch>, Gregory Clement	
 <gregory.clement@...tlin.com>, Sebastian Hesselbarth	
 <sebastian.hesselbarth@...il.com>, Krzysztof Kozlowski <krzk@...nel.org>, 
 Sylwester Nawrocki <s.nawrocki@...sung.com>, Alim Akhtar
 <alim.akhtar@...sung.com>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, 	linux-actions@...ts.infradead.org,
 linux-mips@...r.kernel.org, 	linux-samsung-soc@...r.kernel.org, Bartosz
 Golaszewski	 <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 06/12] pinctrl: ingenic: use new GPIO line value setter
 callbacks

Hi Bartosz,

Le jeudi 24 avril 2025 à 10:35 +0200, Bartosz Golaszewski a écrit :
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> struct gpio_chip now has callbacks for setting line values that
> return
> an integer, allowing to indicate failures. Convert the driver to
> using
> them.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

Acked-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul

> ---
>  drivers/pinctrl/pinctrl-ingenic.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-ingenic.c
> b/drivers/pinctrl/pinctrl-ingenic.c
> index a9e48eac15f6..3c660471ec69 100644
> --- a/drivers/pinctrl/pinctrl-ingenic.c
> +++ b/drivers/pinctrl/pinctrl-ingenic.c
> @@ -3800,12 +3800,14 @@ static void ingenic_gpio_irq_handler(struct
> irq_desc *desc)
>  	chained_irq_exit(irq_chip, desc);
>  }
>  
> -static void ingenic_gpio_set(struct gpio_chip *gc,
> -		unsigned int offset, int value)
> +static int ingenic_gpio_set(struct gpio_chip *gc, unsigned int
> offset,
> +			    int value)
>  {
>  	struct ingenic_gpio_chip *jzgc = gpiochip_get_data(gc);
>  
>  	ingenic_gpio_set_value(jzgc, offset, value);
> +
> +	return 0;
>  }
>  
>  static int ingenic_gpio_get(struct gpio_chip *gc, unsigned int
> offset)
> @@ -4449,7 +4451,7 @@ static int __init ingenic_gpio_probe(struct
> ingenic_pinctrl *jzpc,
>  	jzgc->gc.fwnode = fwnode;
>  	jzgc->gc.owner = THIS_MODULE;
>  
> -	jzgc->gc.set = ingenic_gpio_set;
> +	jzgc->gc.set_rv = ingenic_gpio_set;
>  	jzgc->gc.get = ingenic_gpio_get;
>  	jzgc->gc.direction_input = pinctrl_gpio_direction_input;
>  	jzgc->gc.direction_output = ingenic_gpio_direction_output;