linux-kernel - Re: [PATCH v5 10/14] nvmet-fcloop: don't wait for lport cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05ac9a81-66a9-4bbc-92e0-6ff47a6dc7ad@suse.de>
Date: Thu, 24 Apr 2025 12:21:09 +0200
From: Hannes Reinecke <hare@...e.de>
To: Daniel Wagner <wagi@...nel.org>, James Smart <james.smart@...adcom.com>,
 Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
 Chaitanya Kulkarni <kch@...dia.com>
Cc: Keith Busch <kbusch@...nel.org>, linux-nvme@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 10/14] nvmet-fcloop: don't wait for lport cleanup

On 4/23/25 15:21, Daniel Wagner wrote:
> The lifetime of the fcloop_lsreq is not tight to the lifetime of the
> host or target port, thus there is no need anymore to synchronize the
> cleanup path anymore.
> 
> Signed-off-by: Daniel Wagner <wagi@...nel.org>
> ---
>   drivers/nvme/target/fcloop.c | 21 ++++-----------------
>   1 file changed, 4 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c
> index 47ce51183a66b4b37fc850cced2ddf70be2cdb42..ca11230bffedb0f2313a99e24e54e892daf0d644 100644
> --- a/drivers/nvme/target/fcloop.c
> +++ b/drivers/nvme/target/fcloop.c
> @@ -207,7 +207,6 @@ static LIST_HEAD(fcloop_nports);
>   struct fcloop_lport {
>   	struct nvme_fc_local_port *localport;
>   	struct list_head lport_list;
> -	struct completion unreg_done;
>   	refcount_t ref;
>   };
>   
> @@ -1083,9 +1082,6 @@ fcloop_localport_delete(struct nvme_fc_local_port *localport)
>   	struct fcloop_lport_priv *lport_priv = localport->private;
>   	struct fcloop_lport *lport = lport_priv->lport;
>   
> -	/* release any threads waiting for the unreg to complete */
> -	complete(&lport->unreg_done);
> -
>   	fcloop_lport_put(lport);
>   }
>   
> @@ -1238,18 +1234,9 @@ fcloop_create_local_port(struct device *dev, struct device_attribute *attr,
>   }
>   
>   static int
> -__wait_localport_unreg(struct fcloop_lport *lport)
> +__localport_unreg(struct fcloop_lport *lport)
>   {
> -	int ret;
> -
> -	init_completion(&lport->unreg_done);
> -
> -	ret = nvme_fc_unregister_localport(lport->localport);
> -
> -	if (!ret)
> -		wait_for_completion(&lport->unreg_done);
> -
> -	return ret;
> +	return nvme_fc_unregister_localport(lport->localport);
>   }
>   
>   static struct fcloop_nport *
> @@ -1332,7 +1319,7 @@ fcloop_delete_local_port(struct device *dev, struct device_attribute *attr,
>   	if (!lport)
>   		return -ENOENT;
>   
> -	ret = __wait_localport_unreg(lport);
> +	ret = __localport_unreg(lport);
>   	fcloop_lport_put(lport);
>   
>   	return ret ? ret : count;
> @@ -1776,7 +1763,7 @@ static void __exit fcloop_exit(void)
>   
>   		spin_unlock_irqrestore(&fcloop_lock, flags);
>   
> -		ret = __wait_localport_unreg(lport);
> +		ret = __localport_unreg(lport);
>   		if (ret)
>   			pr_warn("%s: Failed deleting local port\n", __func__);
>   
> 
And who is freeing the allocated fcloop_lsreq structures?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich