linux-kernel - Re: [PATCH net-next v10 3/9] net: devmem: TCP tx netlink api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m21ptiszbx.fsf@gmail.com>
Date: Thu, 24 Apr 2025 10:06:42 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Mina Almasry <almasrymina@...gle.com>
Cc: netdev@...r.kernel.org,  linux-kernel@...r.kernel.org,
  linux-doc@...r.kernel.org,  io-uring@...r.kernel.org,
  virtualization@...ts.linux.dev,  kvm@...r.kernel.org,
  linux-kselftest@...r.kernel.org,  Jakub Kicinski <kuba@...nel.org>,
  "David S. Miller" <davem@...emloft.net>,  Eric Dumazet
 <edumazet@...gle.com>,  Paolo Abeni <pabeni@...hat.com>,  Simon Horman
 <horms@...nel.org>,  Jonathan Corbet <corbet@....net>,  Andrew Lunn
 <andrew+netdev@...n.ch>,  Jeroen de Borst <jeroendb@...gle.com>,
  Harshitha Ramamurthy <hramamurthy@...gle.com>,  Kuniyuki Iwashima
 <kuniyu@...zon.com>,  Willem de Bruijn <willemb@...gle.com>,  Jens Axboe
 <axboe@...nel.dk>,  Pavel Begunkov <asml.silence@...il.com>,  David Ahern
 <dsahern@...nel.org>,  Neal Cardwell <ncardwell@...gle.com>,  Stefan
 Hajnoczi <stefanha@...hat.com>,  Stefano Garzarella <sgarzare@...hat.com>,
  "Michael S. Tsirkin" <mst@...hat.com>,  Jason Wang <jasowang@...hat.com>,
  Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,  Eugenio Pérez
 <eperezma@...hat.com>,  Shuah Khan <shuah@...nel.org>,  sdf@...ichev.me,
  dw@...idwei.uk,  Jamal Hadi Salim <jhs@...atatu.com>,  Victor Nogueira
 <victor@...atatu.com>,  Pedro Tammela <pctammela@...atatu.com>,  Samiullah
 Khawaja <skhawaja@...gle.com>
Subject: Re: [PATCH net-next v10 3/9] net: devmem: TCP tx netlink api

Mina Almasry <almasrymina@...gle.com> writes:
>>
>> The bind-rx op has "flags: [ admin-perm ]", should bind-tx also?
>
> The omission of admin-perm for tx is intentional.
>
> Binding a dmabuf to an rx queue should and is a privileged operation,
> because basically the application doing the binding is taking
> ownership of this rx queue. For TX, no such queue ownership is being
> taken. The TX binding just gives the netdevice access to the dmabuf
> dma-addresses so the netdevice can send from there. It's very similar
> to a normal dma-map with normal memory. There is no need for privilege
> checks.

Thanks for the explanation. I couldn't find any mention of ownership in
the docs.