linux-kernel - Re: [PATCH 3/7] docs: sysfs.rst: document additional attribute group macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6809950dbfbcf_71fe294f3@dwillia2-xfh.jf.intel.com.notmuch>
Date: Wed, 23 Apr 2025 18:34:05 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: "David E. Box" <david.e.box@...ux.intel.com>, <corbet@....net>,
	<bhelgaas@...gle.com>, <kuurtb@...il.com>, <hdegoede@...hat.com>,
	<ilpo.jarvinen@...ux.intel.com>, <vkoul@...nel.org>,
	<yung-chuan.liao@...ux.intel.com>, <pierre-louis.bossart@...ux.dev>,
	<sanyog.r.kale@...el.com>, <gregkh@...uxfoundation.org>, <rafael@...nel.org>,
	<dakr@...nel.org>, <dan.j.williams@...el.com>,
	<andriy.shevchenko@...ux.intel.com>
CC: <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-pci@...r.kernel.org>, <platform-driver-x86@...r.kernel.org>,
	<Dell.Client.Kernel@...l.com>, <linux-sound@...r.kernel.org>
Subject: Re: [PATCH 3/7] docs: sysfs.rst: document additional attribute group
 macros

David E. Box wrote:
> Add documentation to Documentation/filesystems/sysfs.rst for several sysfs
> helper macros, including recently introduced and previously undocumented
> helpers.
> 
> Document the following macros:
> 
> 	__ATTR_IGNORE_LOCKDEP
> 	DEFINE_SYSFS_GROUP_VISIBILITY
> 	DEFINE_SYSFS_BIN_GROUP_VISIBILITY
> 	DEFINE_SYSFS_BIN_GROUP_COMBO_VISIBILITY
> 	ATTRIBUTE_GROUPS
> 	BIN_ATTRIBUTE_GROUPS
> 	NAMED_ATTRIBUTE_GROUP_VISIBLE
> 	NAMED_ATTRIBUTE_GROUPS_VISIBLE
> 	NAMED_ATTRIBUTE_GROUP_COMBO_VISIBLE
> 	NAMED_ATTRIBUTE_GROUPS_COMBO_VISIBLE
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Signed-off-by: David E. Box <david.e.box@...ux.intel.com>
> ---
>  Documentation/filesystems/sysfs.rst | 244 ++++++++++++++++++++++++++++
>  1 file changed, 244 insertions(+)

Looks clean and useful, thanks for taking the time to improve the
documentation.

Reviewed-by: Dan Williams <dan.j.williams@...el.com>