linux-kernel - Re: [PATCH v2] cpufreq: Fix setting policy limits when frequency tables are used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hS9BEAQLUxf983EMgA53euOY837BD4nb2bKE=2htPOWQ@mail.gmail.com>
Date: Fri, 25 Apr 2025 15:30:44 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Stephan Gerhold <stephan.gerhold@...aro.org>
Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>, Linux PM <linux-pm@...r.kernel.org>, 
	Christian Loehle <christian.loehle@....com>, LKML <linux-kernel@...r.kernel.org>, 
	Viresh Kumar <viresh.kumar@...aro.org>, 
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, 
	Mario Limonciello <mario.limonciello@....com>, Sultan Alsawaf <sultan@...neltoast.com>, 
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH v2] cpufreq: Fix setting policy limits when frequency
 tables are used

On Fri, Apr 25, 2025 at 3:21 PM Stephan Gerhold
<stephan.gerhold@...aro.org> wrote:
>
> On Fri, Apr 25, 2025 at 01:36:21PM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> >
> > Commit 7491cdf46b5c ("cpufreq: Avoid using inconsistent policy->min and
> > policy->max") overlooked the fact that policy->min and policy->max were
> > accessed directly in cpufreq_frequency_table_target() and in the
> > functions called by it.  Consequently, the changes made by that commit
> > led to problems with setting policy limits.
> >
> > Address this by passing the target frequency limits to __resolve_freq()
> > and cpufreq_frequency_table_target() and propagating them to the
> > functions called by the latter.
> >
> > Fixes: 7491cdf46b5c ("cpufreq: Avoid using inconsistent policy->min and policy->max")
> > Link: https://lore.kernel.org/linux-pm/aAplED3IA_J0eZN0@linaro.org/
> > Reported-by: Stephan Gerhold <stephan.gerhold@...aro.org>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> Thanks a lot for the quick fix! It works for me. After the CPU frequency
> was throttled due to high temperature and the device has cooled down,
> the CPU frequency goes back to maximum again.
>
> Tested-by: Stephan Gerhold <stephan.gerhold@...aro.org>

Thanks for the quick turnaround!

I want it to spend at least a couple of days in linux-next and I'd
like to give people a chance to review it in case something is still
missing, so my current plan is to push it for -rc5.

Thank you!