linux-kernel - Re: [PATCH net-next v6 06/11] net: ti: prueth: Adds HW timestamping support for PTP using PRU-ICSS IEP module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250424191600.50d7974c@kernel.org>
Date: Thu, 24 Apr 2025 19:16:00 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Parvathi Pudi <parvathi@...thit.com>
Cc: danishanwar@...com, rogerq@...nel.org, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, nm@...com,
 ssantosh@...nel.org, tony@...mide.com, richardcochran@...il.com,
 glaroque@...libre.com, schnelle@...ux.ibm.com, m-karicheri2@...com,
 s.hauer@...gutronix.de, rdunlap@...radead.org, diogo.ivo@...mens.com,
 basharath@...thit.com, horms@...nel.org, jacob.e.keller@...el.com,
 m-malladi@...com, javier.carrasco.cruz@...il.com, afd@...com,
 s-anna@...com, linux-arm-kernel@...ts.infradead.org,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, pratheesh@...com, prajith@...com,
 vigneshr@...com, praneeth@...com, srk@...com, rogerq@...com,
 krishna@...thit.com, pmohan@...thit.com, mohan@...thit.com
Subject: Re: [PATCH net-next v6 06/11] net: ti: prueth: Adds HW timestamping
 support for PTP using PRU-ICSS IEP module

On Wed, 23 Apr 2025 12:53:51 +0530 Parvathi Pudi wrote:
> +static inline void icssm_prueth_ptp_ts_enable(struct prueth_emac *emac)

Also do not use "inline" for functions which are not called from 
the fast path. Basically no "inline" unless you can measure real
perf impact.