linux-kernel - RE: [PATCH v8 09/21] x86/resctrl: Remove a newline to avoid confusing the code move script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <OSZPR01MB87984AA2D054DD6527BB99DE8B842@OSZPR01MB8798.jpnprd01.prod.outlook.com>
Date: Fri, 25 Apr 2025 02:32:16 +0000
From: "Shaopeng Tan (Fujitsu)" <tan.shaopeng@...itsu.com>
To: 'James Morse' <james.morse@....com>, "x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: Reinette Chatre <reinette.chatre@...el.com>, Thomas Gleixner
	<tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov
	<bp@...en8.de>, H Peter Anvin <hpa@...or.com>, Babu Moger
	<Babu.Moger@....com>, "shameerali.kolothum.thodi@...wei.com"
	<shameerali.kolothum.thodi@...wei.com>, D Scott Phillips OS
	<scott@...amperecomputing.com>, "carl@...amperecomputing.com"
	<carl@...amperecomputing.com>, "lcherian@...vell.com" <lcherian@...vell.com>,
	"bobo.shaobowang@...wei.com" <bobo.shaobowang@...wei.com>,
	"baolin.wang@...ux.alibaba.com" <baolin.wang@...ux.alibaba.com>, Jamie Iles
	<quic_jiles@...cinc.com>, Xin Hao <xhao@...ux.alibaba.com>,
	"peternewman@...gle.com" <peternewman@...gle.com>, "dfustini@...libre.com"
	<dfustini@...libre.com>, "amitsinght@...vell.com" <amitsinght@...vell.com>,
	David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>, Dave
 Martin <dave.martin@....com>, Koba Ko <kobak@...dia.com>, Shanker Donthineni
	<sdonthineni@...dia.com>, "fenghuay@...dia.com" <fenghuay@...dia.com>, Babu
 Moger <babu.moger@....com>, Tony Luck <tony.luck@...el.com>
Subject: RE: [PATCH v8 09/21] x86/resctrl: Remove a newline to avoid confusing
 the code move script

Hello 
> The resctrl filesystem code will shortly be moved to /fs/. This involves splitting
> all the existing files, with some functions remaining under arch/x86, and others
> moving to fs/resctrl.
> 
> To make this reproducible, a python script does the heavy lif^W
> copy-and-paste. This involves some clunky parsing of C code.
Is "lif^W" a typo?

Best regards,
Shaopeng TAN

> The parser gets confused by the newline after this #ifdef.
> Just remove it.
> 
> Signed-off-by: James Morse <james.morse@....com>
> Tested-by: Carl Worth <carl@...amperecomputing.com> # arm64
> Tested-by: Shaopeng Tan <tan.shaopeng@...fujitsu.com>
> Tested-by: Peter Newman <peternewman@...gle.com>
> Tested-by: Amit Singh Tomar <amitsinght@...vell.com> # arm64
> Tested-by: Shanker Donthineni <sdonthineni@...dia.com> # arm64
> Tested-by: Babu Moger <babu.moger@....com>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@...fujitsu.com>
> Reviewed-by: Tony Luck <tony.luck@...el.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>
> Reviewed-by: Fenghua Yu <fenghuay@...dia.com>
> ---
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index aa0bc57e1c7f..d61b7137f443 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -899,7 +899,6 @@ static int rdtgroup_rmid_show(struct kernfs_open_file
> *of,  }
> 
>  #ifdef CONFIG_PROC_CPU_RESCTRL
> -
>  /*
>   * A task can only be part of one resctrl control group and of one monitor
>   * group which is associated to that control group.
> --
> 2.20.1