linux-kernel - Re: [PATCH v1 0/1] iio: adc: ad7192: Refactor filter config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ca81b41-f3a2-49a0-ae91-72fb068bb0d5@baylibre.com>
Date: Fri, 25 Apr 2025 10:43:19 -0500
From: David Lechner <dlechner@...libre.com>
To: Alisa-Dariana Roman <alisadariana@...il.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Alisa-Dariana Roman <alisa.roman@...log.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Lars-Peter Clausen <lars@...afoo.de>,
 Michael Hennerich <Michael.Hennerich@...log.com>,
 Jonathan Cameron <jic23@...nel.org>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>
Subject: Re: [PATCH v1 0/1] iio: adc: ad7192: Refactor filter config

On 4/25/25 8:20 AM, Alisa-Dariana Roman wrote:
> Dear maintainers,
> 
> Here is a pretty voluminous patch improving the filter setup for AD7192
> and similar chips.
> 
> I removed the write options for two attributes and I know that is
> questionable. I am sending this version just in case it is still viable
> since I think the driver is a lot cleaner like this.

If you can make the case that no one is using them, e.g. because the function
didn't work correctly, then it could be OK. But best not to break userspace if
we can help it.

For IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY, it seems easy enough to keep
ad7192_set_3db_filter_freq() and just modify it a bit to call the new
ad7192_set_filter_mode() with the 4 previously supported filter types.

And IIO_CHAN_INFO_OVERSAMPLING_RATIO seems like it could be preserved too, but
will take a bit more work. I'll comment more in the patch.

> 
> I also modified the size of the 3db filter low pass available attribute
> since AD7193/AD7194 have 16 filter modes, unlike the other chips that
> have 4.
> 
> Note that I moved a few of the functions around to be able to use them
> where needed.
> 
> Have a great weekend!
> 
> Kind regards,
> Alisa-Dariana Roman.
>