linux-kernel - Re: [PATCH v3 01/14] x86/msr: Move rdtsc{,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42dc90e1-df2a-2324-d28c-d75fb525e4a2@linux.intel.com>
Date: Fri, 25 Apr 2025 18:45:18 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: "Xin Li (Intel)" <xin@...or.com>
cc: LKML <linux-kernel@...r.kernel.org>, kvm@...r.kernel.org, 
    linux-perf-users@...r.kernel.org, linux-hyperv@...r.kernel.org, 
    virtualization@...ts.linux.dev, linux-pm@...r.kernel.org, 
    linux-edac@...r.kernel.org, xen-devel@...ts.xenproject.org, 
    linux-acpi@...r.kernel.org, linux-hwmon@...r.kernel.org, 
    Netdev <netdev@...r.kernel.org>, platform-driver-x86@...r.kernel.org, 
    tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, 
    dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com, 
    acme@...nel.org, jgross@...e.com, andrew.cooper3@...rix.com, 
    peterz@...radead.org, namhyung@...nel.org, mark.rutland@....com, 
    alexander.shishkin@...ux.intel.com, jolsa@...nel.org, irogers@...gle.com, 
    adrian.hunter@...el.com, kan.liang@...ux.intel.com, wei.liu@...nel.org, 
    ajay.kaher@...adcom.com, bcm-kernel-feedback-list@...adcom.com, 
    tony.luck@...el.com, pbonzini@...hat.com, vkuznets@...hat.com, 
    seanjc@...gle.com, luto@...nel.org, boris.ostrovsky@...cle.com, 
    kys@...rosoft.com, haiyangz@...rosoft.com, decui@...rosoft.com, 
    dapeng1.mi@...ux.intel.com
Subject: Re: [PATCH v3 01/14] x86/msr: Move rdtsc{,_ordered}() to
 <asm/tsc.h>

On Fri, 25 Apr 2025, Xin Li (Intel) wrote:

> For some reason, there are some TSC-related functions in the MSR
> header even though there is a tsc.h header.
> 
> Relocate rdtsc{,_ordered}() from <asm/msr.h> to <asm/tsc.h>, and
> subsequently remove the inclusion of <asm/msr.h> in <asm/tsc.h>.
> Consequently, <asm/msr.h> must be included in several source files
> that previously did not require it.
>
> Signed-off-by: Xin Li (Intel) <xin@...or.com>
> Acked-by: Dave Hansen <dave.hansen@...ux.intel.com>
> ---
> 
> Change in v3:
> * Add a problem statement to the changelog (Dave Hansen).
> ---

>  drivers/platform/x86/intel/pmc/cnp.c          |  1 +
>  .../intel/speed_select_if/isst_if_common.c    |  1 +
>  drivers/platform/x86/intel/turbo_max_3.c      |  1 +

Hi,

To me this looks really a random set of source files, maybe it helped some 
build success but it's hard for me to review this because there are still 
cases that depend on indirect include chains.

Could you just look into solving all missing msr.h includes instead 
as clearly some are still missing after 3 pre-existing ones and you adding 
it into 3 files:

$ git grep -e rdmsr -e wrmsr -l drivers/platform/x86/
drivers/platform/x86/intel/ifs/core.c
drivers/platform/x86/intel/ifs/load.c
drivers/platform/x86/intel/ifs/runtest.c
drivers/platform/x86/intel/pmc/cnp.c
drivers/platform/x86/intel/pmc/core.c
drivers/platform/x86/intel/speed_select_if/isst_if_common.c
drivers/platform/x86/intel/speed_select_if/isst_if_mbox_msr.c
drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
drivers/platform/x86/intel/tpmi_power_domains.c
drivers/platform/x86/intel/turbo_max_3.c
drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c
drivers/platform/x86/intel_ips.c

$ git grep -e 'msr.h' -l drivers/platform/x86/
drivers/platform/x86/intel/pmc/core.c
drivers/platform/x86/intel/tpmi_power_domains.c
drivers/platform/x86/intel_ips.c

I'd also prefer the patch(es) adding missing includes be in a different 
patch.

-- 
 i.