linux-kernel - Re: [PATCH] iio: adc: ad7173: fix compiling without gpiolib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vc4L3NukGriXHUu3=XjU_d-V1qL6tQcFtgcyC7A8WKPSw@mail.gmail.com>
Date: Fri, 25 Apr 2025 21:08:06 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: David Lechner <dlechner@...libre.com>
Cc: Jonathan Cameron <jic23@...nel.org>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, 
	Michael Hennerich <Michael.Hennerich@...log.com>, Guillaume Ranquet <granquet@...libre.com>, 
	Jonathan Cameron <Jonathan.Cameron@...wei.com>, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] iio: adc: ad7173: fix compiling without gpiolib

On Fri, Apr 25, 2025 at 7:55 PM David Lechner <dlechner@...libre.com> wrote:
> On 4/22/25 4:03 PM, Andy Shevchenko wrote:
> > On Tue, Apr 22, 2025 at 11:12 PM David Lechner <dlechner@...libre.com> wrote:

> >> Fix compiling the ad7173 driver when CONFIG_GPIOLIB is not set by
> >> selecting GPIOLIB to be always enabled and remove the #if.
> >
> > I'm not sure we need to select GPIOLIB. If you want it, depend on it.
> > GPIOLIB is not a hidden symbol, so why "select"?
> >
> Since this parts of the driver unrelated to GPIO provider/consumer rely on this
> being enabled to function, select seems more appropriate.

Hmm... The current state of affairs is 177 for select vs. 231 for
depends on. I dunno how many of them are historical, for now it seems
like 40%/60%. So if you think so, go for it!


-- 
With Best Regards,
Andy Shevchenko