linux-kernel - Re: [PATCH v1] arm64: dts: imx8qm: add ethernet aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <32ec4e3f-9a5f-48b1-b87d-62fd5debc018@kernel.org>
Date: Fri, 25 Apr 2025 21:22:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Francesco Dolcini <francesco@...cini.it>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>
Cc: Francesco Dolcini <francesco.dolcini@...adex.com>,
 devicetree@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] arm64: dts: imx8qm: add ethernet aliases

On 25/04/2025 18:39, Krzysztof Kozlowski wrote:
> On 25/04/2025 18:36, Krzysztof Kozlowski wrote:
>> On 22/04/2025 12:02, Francesco Dolcini wrote:
>>> From: Francesco Dolcini <francesco.dolcini@...adex.com>
>>>
>>> Add ethernet aliases, they are used by the firmware to set the MAC
>>> address and by systemd to rename network interfaces to predictable
>>> interface names, e.g. end0 and end1.
>>>
>>> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
>>> ---
>>>  arch/arm64/boot/dts/freescale/imx8qm.dtsi | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>>> index 6fa31bc9ece8..eccd0087efa7 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>>> +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>>> @@ -17,6 +17,8 @@ / {
>>>  	#size-cells = <2>;
>>>  
>>>  	aliases {
>>> +		ethernet0 = &fec1;
>>> +		ethernet1 = &fec2;
>> Can't they be disabled (e.g. because MAC is external?) on actual board?
>> IOW, aliases for exposed interfaces are properties of boards, not SoC.
>>
>> What's more, I cannot find these in this DTSI, so how can you add alias
>> to non-existing node?
> 
> I found them (terrible design by NXP) but they are disabled so that's
> the point - adding aliases to disabled nodes is clear sign you are doing
> it wrong.

I'll fix existing NXP boards because this pattern of adding aliases for
disabled (thus non-existing) interface is in multiple places.

Best regards,
Krzysztof