| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250425195237.493129-4-xi.pardee@linux.intel.com> Date: Fri, 25 Apr 2025 12:52:31 -0700 From: Xi Pardee <xi.pardee@...ux.intel.com> To: xi.pardee@...ux.intel.com, irenic.rajneesh@...il.com, david.e.box@...ux.intel.com, hdegoede@...hat.com, ilpo.jarvinen@...ux.intel.com, platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org Subject: [PATCH v5 3/5] platform/x86:intel/pmc: Use devm for mutex_init Use devm_mutex_init() to avoid accidental resource leak in the future. Signed-off-by: Xi Pardee <xi.pardee@...ux.intel.com> --- drivers/platform/x86/intel/pmc/core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c index 2028a769cddb..db3fccca06fb 100644 --- a/drivers/platform/x86/intel/pmc/core.c +++ b/drivers/platform/x86/intel/pmc/core.c @@ -1681,7 +1681,6 @@ static void pmc_core_clean_structure(struct platform_device *pdev) pmt_telem_unregister_endpoint(pmcdev->punit_ep); platform_set_drvdata(pdev, NULL); - mutex_destroy(&pmcdev->lock); } static int pmc_core_probe(struct platform_device *pdev) @@ -1726,7 +1725,9 @@ static int pmc_core_probe(struct platform_device *pdev) if (!pmcdev->pkgc_res_cnt) return -ENOMEM; - mutex_init(&pmcdev->lock); + ret = devm_mutex_init(&pdev->dev, &pmcdev->lock); + if (ret) + return ret; if (pmc_dev_info->init) ret = pmc_dev_info->init(pmcdev, pmc_dev_info); -- 2.43.0
Powered by blists - more mailing lists