linux-kernel - Re: [PATCH v5 3/5] arm64: dts: qcom: Add initial support for MSM8937

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31559417a92d1e1ff17d0f3add9a1ba0@mainlining.org>
Date: Fri, 25 Apr 2025 22:22:39 +0200
From: barnabas.czeman@...nlining.org
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>, Michael Turquette
 <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Stephan Gerhold <stephan@...hold.net>,
 Otto Pflüger <otto.pflueger@...cue.de>, Linus Walleij
 <linus.walleij@...aro.org>, Lee Jones <lee@...nel.org>, Joerg Roedel
 <joro@...tes.org>, Will Deacon <will@...nel.org>, Robin Murphy
 <robin.murphy@....com>, Konrad Dybcio <konradybcio@...nel.org>, Rob Clark
 <robdclark@...il.com>, Sean Paul <sean@...rly.run>, Abhinav Kumar
 <quic_abhinavk@...cinc.com>, Marijn Suijten <marijn.suijten@...ainline.org>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Maarten
 Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Dmitry
 Baryshkov <lumag@...nel.org>, Adam Skladowski <a_skl39@...tonmail.com>,
 Sireesh Kodali <sireeshkodali@...tonmail.com>, Srinivas Kandagatla
 <srini@...nel.org>, linux-arm-msm@...r.kernel.org,
 linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
 iommu@...ts.linux.dev, dri-devel@...ts.freedesktop.org,
 freedreno@...ts.freedesktop.org, phone-devel@...r.kernel.org,
 ~postmarketos/upstreaming@...ts.sr.ht, linux@...nlining.org, Dang Huynh
 <danct12@...eup.net>
Subject: Re: [PATCH v5 3/5] arm64: dts: qcom: Add initial support for MSM8937

On 2025-04-25 21:26, Konrad Dybcio wrote:
> On 4/25/25 5:13 PM, barnabas.czeman@...nlining.org wrote:
>> On 2025-04-25 11:57, Konrad Dybcio wrote:
>>> On 4/23/25 4:46 PM, barnabas.czeman@...nlining.org wrote:
>>>> On 2025-04-23 16:03, Konrad Dybcio wrote:
>>>>> On 4/21/25 10:18 PM, Barnabás Czémán wrote:
>>>>>> From: Dang Huynh <danct12@...eup.net>
>>>>>> 
>>>>>> Add initial support for MSM8937 SoC.
>>>>>> 
>>>>>> Signed-off-by: Dang Huynh <danct12@...eup.net>
>>>>>> Co-developed-by: Barnabás Czémán <barnabas.czeman@...nlining.org>
>>>>>> Signed-off-by: Barnabás Czémán <barnabas.czeman@...nlining.org>
>>>>>> ---
>>> 
>>> [...]
>>> 
>>>>>> +            gpu_opp_table: opp-table {
>>>>>> +                compatible = "operating-points-v2";
>>>>>> +
>>>>>> +                opp-19200000 {
>>>>>> +                    opp-hz = /bits/ 64 <19200000>;
>>>>>> +                    opp-supported-hw = <0xff>;
>>>>> 
>>>>> The comment from the previous revision still stands
>>>> If i remove opp-supported-hw i will got -22 EINVAL messages and the 
>>>> opp will be not fine.
>>> 
>>> Right, I have a series pending to improve this situation a bit..
>>> 
>>> In the meantime, you should be able to define the nvmem cell and
>>> fill in meaningful values for this platform
>> As I wrote in the previous revision there is no nvmem for GPU on 
>> msm8937 only on msm8940.
> 
> This seems not to be the case
> 
> https://github.com/penglezos/android_kernel_xiaomi_msm8953/blob/pie/arch/arm/boot/dts/qcom/msm8937.dtsi#L2046-L2191
> 
These are on msm-4.9 was moved to msm8940.dtsi
https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LA.UM.10.6.2.c26-01500-89xx.0/arch/arm64/boot/dts/qcom/msm8937-gpu.dtsi#L162
https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LA.UM.10.6.2.c26-01500-89xx.0/arch/arm64/boot/dts/qcom/msm8940.dtsi#L600
475 MHz and 500 MHz is for msm8940 at least based on 4.9


> Konrad