linux-kernel - Re: [PATCH v4 1/7] mm: Introduce for_each_valid_pfn() and use it from reserve_bootmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d828f037583bf1a4380fd02b1156befa11128d89.camel@infradead.org>
Date: Fri, 25 Apr 2025 23:01:58 +0100
From: David Woodhouse <dwmw2@...radead.org>
To: David Hildenbrand <david@...hat.com>, Mike Rapoport <rppt@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, "Sauerwein, David"
 <dssauerw@...zon.de>, Anshuman Khandual <anshuman.khandual@....com>, Ard
 Biesheuvel <ardb@...nel.org>, Catalin Marinas <catalin.marinas@....com>,
 Marc Zyngier <maz@...nel.org>,  Mark Rutland <mark.rutland@....com>, Mike
 Rapoport <rppt@...ux.ibm.com>, Will Deacon <will@...nel.org>, 
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
 linux-mm@...ck.org, Ruihan Li <lrh2000@....edu.cn>
Subject: Re: [PATCH v4 1/7] mm: Introduce for_each_valid_pfn() and use it
 from reserve_bootmem_region()

On Thu, 2025-04-24 at 23:11 +0200, David Hildenbrand wrote:
> 
> > +	unsigned long pfn;
> >    
> > -	for (; start_pfn < end_pfn; start_pfn++) {
> > -		if (pfn_valid(start_pfn)) {
> > -			struct page *page = pfn_to_page(start_pfn);
> > +	for_each_valid_pfn (pfn, PFN_DOWN(start), PFN_UP(end)) {
> 
>                            ^ space should be removed


I was treating for_each_foobar() like for(), which always *does* have
the space before the parentheses. But a quick grep shows that that's
the minority, by at least two orders of magnitude. Fixing it locally;
thanks.


Download attachment "smime.p7s" of type "application/pkcs7-signature" (5069 bytes)