linux-kernel - Re: [PATCH v2 RESEND] fpga: fix potential null pointer deref in fpga_mgr_test_img_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAsP5qZ9+kGcmps0@yilunxu-OptiPlex-7050>
Date: Fri, 25 Apr 2025 12:30:30 +0800
From: Xu Yilun <yilun.xu@...ux.intel.com>
To: Qasim Ijaz <qasdev00@...il.com>
Cc: mdf@...nel.org, hao.wu@...el.com, yilun.xu@...el.com, trix@...hat.com,
	akpm@...ux-foundation.org, marpagan@...hat.com, arnd@...db.de,
	linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
	Marco Pagani <marco.pagani@...ux.dev>
Subject: Re: [PATCH v2 RESEND] fpga: fix potential null pointer deref in
 fpga_mgr_test_img_load_sgt()

On Tue, Apr 22, 2025 at 04:37:37PM +0100, Qasim Ijaz wrote:
> fpga_mgr_test_img_load_sgt() allocates memory for sgt using
> kunit_kzalloc() however it does not check if the allocation failed. 
> It then passes sgt to sg_alloc_table(), which passes it to
> __sg_alloc_table(). This function calls memset() on sgt in an attempt to
> zero it out. If the allocation fails then sgt will be NULL and the
> memset will trigger a NULL pointer dereference.
> 
> Fix this by checking the allocation with KUNIT_ASSERT_NOT_ERR_OR_NULL().
> 
> Reviewed-by: Marco Pagani <marco.pagani@...ux.dev>
> Fixes: ccbc1c302115 ("fpga: add an initial KUnit suite for the FPGA Manager")
> Signed-off-by: Qasim Ijaz <qasdev00@...il.com>

Acked-by: Xu Yilun <yilun.xu@...el.com>

Applied to for-next.

> ---
> v2:
> - Remove stable CC tag since its just a kunit test
> 
>  drivers/fpga/tests/fpga-mgr-test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/fpga/tests/fpga-mgr-test.c b/drivers/fpga/tests/fpga-mgr-test.c
> index 9cb37aefbac4..1902ebf5a298 100644
> --- a/drivers/fpga/tests/fpga-mgr-test.c
> +++ b/drivers/fpga/tests/fpga-mgr-test.c
> @@ -263,6 +263,7 @@ static void fpga_mgr_test_img_load_sgt(struct kunit *test)
>  	img_buf = init_test_buffer(test, IMAGE_SIZE);
>  
>  	sgt = kunit_kzalloc(test, sizeof(*sgt), GFP_KERNEL);
> +	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, sgt);
>  	ret = sg_alloc_table(sgt, 1, GFP_KERNEL);
>  	KUNIT_ASSERT_EQ(test, ret, 0);
>  	sg_init_one(sgt->sgl, img_buf, IMAGE_SIZE);
> -- 
> 2.39.5
> 
>