[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250425044747-GYA50408@gentoo>
Date: Fri, 25 Apr 2025 04:47:47 +0000
From: Yixun Lan <dlan@...too.org>
To: Chen-Yu Tsai <wens@...e.org>
Cc: Chukun Pan <amadeus@....edu.cn>, andre.przywara@....com,
conor+dt@...nel.org, devicetree@...r.kernel.org,
jernej.skrabec@...il.com, krzk+dt@...nel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-sunxi@...ts.linux.dev, robh@...nel.org, samuel@...lland.org
Subject: Re: [PATCH 1/1] arm64: dts: allwinner: correct the model name for
Radxa Cubie A5E
Hi Chukun, Chen-Yu,
On 11:52 Fri 25 Apr , Chen-Yu Tsai wrote:
> On Fri, Apr 25, 2025 at 11:00 AM Chukun Pan <amadeus@....edu.cn> wrote:
> >
> > Hi,
> >
> > > It seems I'm a little bit late for this, but while we are here,
> > > Can we also append 'cubie' to dts file name?
> > > e.g. - sun55i-a527-radxa-cubie-a5e.dts
> >
> > Usually we use the device name (without the vendor name),
> > maybe sun55i-a527-cubie-a5e.dts would be better?
>
> I agree with this one.
>
I personally would prefer to keep vendor name, it's more explicit
and easy for poeple to distinguish/find the board dts
but, this isn't something I really care, so I won't insist on this,
please proceed either way, thanks
> I can probably squash in a name change (since I'll be squashing in the
> SD card slot fix anyway). Andre?
>
I think it is better
>
> In that case would you prefer to keep your current patch separate, or
> squashed in so that everything is clean from the first commit?
>
> It's up to you since you lose out on commit stats.
>
>
> Thanks
> ChenYu
>
> > Thanks,
> > Chukun
> >
> > --
> > 2.25.1
> >
> >
--
Yixun Lan (dlan)
Powered by blists - more mailing lists