linux-kernel - Re: [PATCH v3] dt-bindings: arm: qcom: add SA8255p Ride board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e98d181a-f7d1-45b7-afa2-fa31563e8db7@quicinc.com>
Date: Thu, 24 Apr 2025 22:19:29 -0700
From: Deepti Jaggi <quic_djaggi@...cinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <andersson@...nel.org>, <konradybcio@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_ptalari@...cinc.com>,
        <quic_psodagud@...cinc.com>, <quic_shazhuss@...cinc.com>
Subject: Re: [PATCH v3] dt-bindings: arm: qcom: add SA8255p Ride board



On 4/23/25 23:17, Krzysztof Kozlowski wrote:
> On 24/04/2025 01:54, Deepti Jaggi wrote:
>>
>> On 4/23/25 05:00, Krzysztof Kozlowski wrote:
>>> On 23/04/2025 02:38, Deepti Jaggi wrote:
>>>> From: Nikunj Kela <quic_nkela@...cinc.com>
>>>>
>>>> Document the SA8255p SoC and its reference board: sa8255p-ride.
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>>> Signed-off-by: Nikunj Kela <quic_nkela@...cinc.com>
>>>> Signed-off-by: Deepti Jaggi <quic_djaggi@...cinc.com>
>>>> ---
>>>> Changes in v3:
>>>> 	Removed the patches from original series[1]
>>>
>>> Why? This makes no sense on its own. Binding goes with the user. No
>>> user? No binding.
>>
>> Thanks for taking the time to review the patch.
>> All the bindings that were initially included in the original series [1]
>> were removed and posted as individual patches.
>> devicetree has been posted as a separate patch :
>> Link: https://lore.kernel.org/all/20250422231249.871995-1-quic_djaggi@quicinc.com
>> If necessary, I can consolidate the bindings and dt into a single series
>> for the next version.
> I asked why and that's not the answer to why. That's description of what
> you did, but we see it here. Anyway, I explained you the process.

By examining other patches that were split from the series by the author, 
it appears that it was advised to split the patches based on subsystem.
However, I do not have any further details.

I followed the approach used for other bindings [1] [2] [3], which were part
of the original series and were sent as separate patches and accepted.
I misjudged that the SoC binding could also be sent as a 
separate patch. I will combine the remaining bindings along with 
the device tree (DT) into a single series in the next revision.

[1]: https://lore.kernel.org/all/20240910165926.2408630-1-quic_nkela@quicinc.com/ 
[2]: https://lore.kernel.org/all/20240910171534.2412263-1-quic_nkela@quicinc.com/ 
[3]: https://lore.kernel.org/all/20240905194741.3803345-1-quic_nkela@quicinc.com/ 

> 
> Best regards,
> Krzysztof