linux-kernel - Re: [net-next v7 4/7] net: mtip: The L2 switch driver for imx287

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bf77ef6-d884-44d2-8ecc-a530fee215d1@kernel.org>
Date: Fri, 25 Apr 2025 07:33:17 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>, Lukasz Majewski <lukma@...x.de>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, davem@...emloft.net,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>,
 Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 Stefan Wahren <wahrenst@....net>, Simon Horman <horms@...nel.org>,
 Andrew Lunn <andrew@...n.ch>
Subject: Re: [net-next v7 4/7] net: mtip: The L2 switch driver for imx287

On 25/04/2025 03:11, Jakub Kicinski wrote:
> On Wed, 23 Apr 2025 09:29:08 +0200 Lukasz Majewski wrote:
>> This patch series provides support for More Than IP L2 switch embedded
>> in the imx287 SoC.
>>
>> This is a two port switch (placed between uDMA[01] and MAC-NET[01]),
>> which can be used for offloading the network traffic.
>>
>> It can be used interchangeably with current FEC driver - to be more
>> specific: one can use either of it, depending on the requirements.
>>
>> The biggest difference is the usage of DMA - when FEC is used, separate
>> DMAs are available for each ENET-MAC block.
>> However, with switch enabled - only the DMA0 is used to send/receive data
>> to/form switch (and then switch sends them to respecitive ports).
> 
> Lots of sparse warnings and build issues here, at least on x86.
> 
> Could you make sure it's clean with an allmodconfig config, 
> something like:
> 
> make C=1 W=1 drivers/net/ethernet/freescale/mtipsw/ 

... and W=1 with clang as well.

Best regards,
Krzysztof