linux-kernel - RE: [PATCH] ufs: core: Remove redundant query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PH7PR16MB61962DED035E3F1F5F03B142E5842@PH7PR16MB6196.namprd16.prod.outlook.com>
Date: Fri, 25 Apr 2025 05:38:43 +0000
From: Avri Altman <Avri.Altman@...disk.com>
To: "keosung.park@...sung.com" <keosung.park@...sung.com>, ALIM AKHTAR
	<alim.akhtar@...sung.com>, "avri.altman@....com" <avri.altman@....com>,
	"bvanassche@....org" <bvanassche@....org>,
	"James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "peter.wang@...iatek.com"
	<peter.wang@...iatek.com>, "manivannan.sadhasivam@...aro.org"
	<manivannan.sadhasivam@...aro.org>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ufs: core: Remove redundant query_complete trace

> The query_complete trace was not removed after ufshcd_issue_dev_cmd()
> was called from the bsg path, resulting in duplicate output.
> 
> Below is an example of the trace:
> 
>  ufs-utils-773     [000] .....   218.176933: ufshcd_upiu: query_send:
> 0000:00:04.0: HDR:16 00 00 1f 00 01 00 00 00 00 00 00, OSF:03 07 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00
>  ufs-utils-773     [000] .....   218.177145: ufshcd_upiu: query_complete:
> 0000:00:04.0: HDR:36 00 00 1f 00 01 00 00 00 00 00 00, OSF:03 07 00 00 00
> 00 00 00 00 00 00 08 00 00 00 00
>  ufs-utils-773     [000] .....   218.177146: ufshcd_upiu: query_complete:
> 0000:00:04.0: HDR:36 00 00 1f 00 01 00 00 00 00 00 00, OSF:03 07 00 00 00
> 00 00 00 00 00 00 08 00 00 00 00
> 
> This commit removes the redundant trace call in the bsg path, preventing
> duplication.
> 

Fixes: 71aabb747d5f ("scsi: ufs: core: Reuse exec_dev_cmd")
> Signed-off-by: Keoseong Park <keosung.park@...sung.com>
Reviewed-by: Avri Altman <avri.altman@...disk.com>

> ---
>  drivers/ufs/core/ufshcd.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index be65fc4b5ccd..c78c7ad4e393 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -7271,8 +7271,6 @@ static int ufshcd_issue_devman_upiu_cmd(struct
> ufs_hba *hba,
>  			err = -EINVAL;
>  		}
>  	}
> -	ufshcd_add_query_upiu_trace(hba, err ? UFS_QUERY_ERR :
> UFS_QUERY_COMP,
> -				    (struct utp_upiu_req *)lrbp->ucd_rsp_ptr);
> 
>  	return err;
>  }
> --
> 2.25.1
>