linux-kernel - RE: [PATCH v2] iwlegacy: 4965: fix possible out-of-bounds access in il4965_tx_cmd_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ea0ce54e06104682b9a5d24b9bb75a91@realtek.com>
Date: Fri, 25 Apr 2025 05:59:27 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Alexei Safin <a.safin@...a.ru>, Stanislaw Gruszka <stf_xl@...pl>
CC: Kalle Valo <kvalo@...nel.org>, "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        "Paolo
 Abeni" <pabeni@...hat.com>,
        "linux-wireless@...r.kernel.org"
	<linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "lvc-project@...uxtesting.org"
	<lvc-project@...uxtesting.org>
Subject: RE: [PATCH v2] iwlegacy: 4965: fix possible out-of-bounds access in il4965_tx_cmd_build_rate()

Alexei Safin <a.safin@...a.ru> wrote:
> 
> Prevent out-of-bounds access in il4965_tx_cmd_build_rate() by rejecting
> rate_idx values greater than or equal to RATE_COUNT_LEGACY.
> 
> Use a correct bounds check to avoid accessing il_rates[] with
> an invalid index. The previous comparison allowed rate_idx to become
> equal to RATE_COUNT_LEGACY, which exceeds the array limit.
> 
> Replace the check 'rate_idx > RATE_COUNT_LEGACY' with
> 'rate_idx >= RATE_COUNT_LEGACY' to ensure memory safety.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 7ac9a364c172 ("iwlegacy: move under intel directory")

The Fixes is obviously wrong. It just moved the code. 

> Signed-off-by: Alexei Safin <a.safin@...a.ru>
> ---
> v2: change reciepent
>  drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> index 78dee8ccfebf..f60d9b9798c1 100644
> --- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> +++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> @@ -1572,7 +1572,7 @@ il4965_tx_cmd_build_rate(struct il_priv *il,
>          */
>         rate_idx = info->control.rates[0].idx;
>         if ((info->control.rates[0].flags & IEEE80211_TX_RC_MCS) || rate_idx < 0
> -           || rate_idx > RATE_COUNT_LEGACY)
> +           || rate_idx >= RATE_COUNT_LEGACY)
>                 rate_idx = rate_lowest_index(&il->bands[info->band], sta);
>         /* For 5 GHZ band, remap mac80211 rate indices into driver indices */
>         if (info->band == NL80211_BAND_5GHZ)
> --
> 2.39.5 (Apple Git-154)
>