linux-kernel - Re: [PATCH 4/5] cdx: controller: Do not open-code module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7b61835-e139-43f9-b402-ca49c2a95dce@linaro.org>
Date: Fri, 25 Apr 2025 08:59:21 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Nipun Gupta <nipun.gupta@....com>, Nikhil Agarwal
 <nikhil.agarwal@....com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] cdx: controller: Do not open-code
 module_platform_driver()

On 25/04/2025 08:54, Krzysztof Kozlowski wrote:
> Replace standard platform_driver_register() boilerplate with
> module_platform_driver() to make code smaller.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/cdx/controller/cdx_controller.c | 20 +-------------------
>  1 file changed, 1 insertion(+), 19 deletions(-)
> 
> diff --git a/drivers/cdx/controller/cdx_controller.c b/drivers/cdx/controller/cdx_controller.c
> index fce90926d3378ae60166426cbf8e4a4fe014af86..fca83141e3e66e68e6916077833db2b7d816395f 100644
> --- a/drivers/cdx/controller/cdx_controller.c
> +++ b/drivers/cdx/controller/cdx_controller.c
> @@ -243,31 +243,13 @@ MODULE_DEVICE_TABLE(of, cdx_match_table);
>  static struct platform_driver cdx_pdriver = {
>  	.driver = {
>  		   .name = "cdx-controller",
> -		   .pm = NULL,


Too big chunk in `git add -p`. This should be separate patch.

I will wait a day for more reviews and then send v2.


Best regards,
Krzysztof