linux-kernel - RE: [PATCH net-next v4 1/2] net: stmmac: Refactor VLAN implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BN8PR03MB5073A348B4FFD53E11604E74B4842@BN8PR03MB5073.namprd03.prod.outlook.com>
Date: Fri, 25 Apr 2025 07:08:36 +0000
From: "Ng, Boon Khai" <boon.khai.ng@...era.com>
To: Paolo Abeni <pabeni@...hat.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre
 Torgue <alexandre.torgue@...s.st.com>, Russell King <linux@...linux.org.uk>,
	Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
	Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend
	<john.fastabend@...il.com>, Furong Xu <0x1207@...il.com>, "Gerlach, Matthew"
	<matthew.gerlach@...era.com>, "Ang, Tien Sung" <tien.sung.ang@...era.com>,
	"Tham, Mun Yew" <mun.yew.tham@...era.com>, "G Thomas, Rohan"
	<rohan.g.thomas@...era.com>
Subject: RE: [PATCH net-next v4 1/2] net: stmmac: Refactor VLAN implementation

> 
> This patch does IMHO too many things together, and should be split in several
> ones, i.e.:
> - just moving the code in a separate file
> - rename functions and simbols.
> - other random changes...
> 

Hi Paolo,

Thanks for the comment, 
sure, will divide this rework into two patches with
1) just moving the code in a separate file
2) rename functions and symbols

- will not include random changes, will explain on that below.

> > +
> > +     netdev_err(dev, "Timeout accessing MAC_VLAN_Tag_Filter\n");
> > +
> > +     return -EBUSY;
> 
> ... like the above on (which looks unnecessary?!?)
> 

These changes were not intended. Last year when I was porting
from dwmac4 to stmmac_vlan.c, I was unaware of new changes in the 
VLAN function. I relied too heavily on Git to alert me to conflicting
Changes on the updated function. Little did I know that when 
I removed code from dwmac4, I will cross-check the latest changes
and submit them again in v5, together with the separated commit.

Regards,
Boon Khai.