linux-kernel - Re: [PATCH v2] bus: mhi: host: don't free bhie tables during suspend/hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1136c7cb-1c7b-410b-93d2-c74aec939196@collabora.com>
Date: Fri, 25 Apr 2025 12:14:39 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: Johannes Berg <johannes@...solutions.net>,
 Jeff Johnson <jjohnson@...nel.org>, Jeffrey Hugo <quic_jhugo@...cinc.com>,
 Yan Zhen <yanzhen@...o.com>, Youssef Samir <quic_yabdulra@...cinc.com>,
 Qiang Yu <quic_qianyu@...cinc.com>, Alex Elder <elder@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Kunwu Chan <chentao@...inos.cn>, kernel@...labora.com, mhi@...ts.linux.dev,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-wireless@...r.kernel.org, ath11k@...ts.infradead.org
Subject: Re: [PATCH v2] bus: mhi: host: don't free bhie tables during
 suspend/hibernation

On 4/25/25 12:04 PM, Manivannan Sadhasivam wrote:
> On Thu, Apr 10, 2025 at 07:56:54PM +0500, Muhammad Usama Anjum wrote:
>> Fix dma_direct_alloc() failure at resume time during bhie_table
>> allocation. There is a crash report where at resume time, the memory
>> from the dma doesn't get allocated and MHI fails to re-initialize.
>> There may be fragmentation of some kind which fails the allocation
>> call.
>>
> 
> If dma_direct_alloc() fails, then it is a platform limitation/issue. We cannot
> workaround that in the device drivers. What is the guarantee that other drivers
> will also continue to work? Will you go ahead and patch all of them which
> release memory during suspend?
> 
> Please investigate why the allocation fails. Even this is not a device issue, so
> we cannot add quirks :/
This isn't a platform specific quirk. We are only hitting it because
there is high memory pressure during suspend/resume. This dma allocation
failure can happen with memory pressure on any device.

The purpose of this patch is just to make driver more robust to memory
pressure during resume.

I'm not sure about MHI. But other drivers already have such patches as
dma_direct_alloc() is susceptible to failures when memory pressure is
high. This patch was motivated from ath12k [1] and ath11k [2].

[1]
https://lore.kernel.org/all/20240419034034.2842-1-quic_bqiang@quicinc.com/
[2]
https://lore.kernel.org/all/20220506141448.10340-1-quic_akolli@quicinc.com/

What do you think can be the way forward for this patch?

> 
>> To fix it, don't free the memory at power down during suspend /
>> hibernation. Instead, use the same allocated memory again after every
>> resume / hibernation. This patch has been tested with resume and
>> hibernation both.
>>
>> The rddm is of constant size for a given hardware. While the fbc_image
>> size depends on the firmware. If the firmware changes, we'll free and
>> allocate new memory for it.
>>
>> Here are the crash logs:
>>
>> [ 3029.338587] mhi mhi0: Requested to power ON
>> [ 3029.338621] mhi mhi0: Power on setup success
>> [ 3029.668654] kworker/u33:8: page allocation failure: order:7, mode:0xc04(GFP_NOIO|GFP_DMA32), nodemask=(null),cpuset=/,mems_allowed=0
>> [ 3029.668682] CPU: 4 UID: 0 PID: 2744 Comm: kworker/u33:8 Not tainted 6.11.11-valve10-1-neptune-611-gb69e902b4338 #1ed779c892334112fb968aaa3facf9686b5ff0bd7
>> [ 3029.668690] Hardware name: Valve Galileo/Galileo, BIOS F7G0112 08/01/2024
> 
> Did you intend to leak this information? If not, please remove it from
> stacktrace.
The device isn't private. Its fine.

> 
> - Mani
> 


-- 
Regards,
Usama