linux-kernel - Re: [PATCH] media: imx335: Use correct register width for HNUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAtAtp2epJCs0RaN@valkosipuli.retiisi.eu>
Date: Fri, 25 Apr 2025 07:58:46 +0000
From: Sakari Ailus <sakari.ailus@....fi>
To: Kieran Bingham <kieran.bingham@...asonboard.com>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Umang Jain <umang.jain@...asonboard.com>
Subject: Re: [PATCH] media: imx335: Use correct register width for HNUM

Hi Kieran,

On Tue, Apr 22, 2025 at 01:20:52PM +0100, Kieran Bingham wrote:
> From: Umang Jain <umang.jain@...asonboard.com>
> 
> CCI_REG_HNUM should be using CCI_REG16_LE() instead of CCI_REG8()
> as HNUM spans from 0x302e[0:7] to 0x302f[0:3].
> 
> Signed-off-by: Umang Jain <umang.jain@...asonboard.com>
> Signed-off-by: Kieran Bingham <kieran.bingham@...asonboard.com>

Does this need Fixes:/Cc: stable tags?

> ---
>  drivers/media/i2c/imx335.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
> index db424b178e98..0418875e996c 100644
> --- a/drivers/media/i2c/imx335.c
> +++ b/drivers/media/i2c/imx335.c
> @@ -31,7 +31,7 @@
>  #define IMX335_REG_CPWAIT_TIME		CCI_REG8(0x300d)
>  #define IMX335_REG_WINMODE		CCI_REG8(0x3018)
>  #define IMX335_REG_HTRIMMING_START	CCI_REG16_LE(0x302c)
> -#define IMX335_REG_HNUM			CCI_REG8(0x302e)
> +#define IMX335_REG_HNUM			CCI_REG16_LE(0x302e)
>  
>  /* Lines per frame */
>  #define IMX335_REG_VMAX			CCI_REG24_LE(0x3030)

-- 
Regards,

Sakari Ailus