linux-kernel - Re: [PATCH 1/2] dt-bindings: ata: rockchip-dwc-ahci: add RK3576 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAtBCgthlNieNUx5@ryzen>
Date: Fri, 25 Apr 2025 10:00:10 +0200
From: Niklas Cassel <cassel@...nel.org>
To: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
Cc: Damien Le Moal <dlemoal@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Serge Semin <fancer.lancer@...il.com>, kernel@...labora.com,
	Sebastian Reichel <sebastian.reichel@...labora.com>,
	linux-ide@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: ata: rockchip-dwc-ahci: add RK3576
 compatible

On Thu, Apr 24, 2025 at 08:52:22PM +0200, Nicolas Frattaroli wrote:
> The Rockchip RK3576 has two SATA controllers. They work the same as the
> RK3568 SATA controllers, having the same number of clocks and ports.
> 
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
> ---
>  Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml b/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
> index 13eaa8d9a16e5a4bd43b3e184f9277494acf27a1..b5ecaabfe2e2537afe6093558fb0ab975dcf6058 100644
> --- a/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
> +++ b/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
> @@ -20,6 +20,7 @@ select:
>        contains:
>          enum:
>            - rockchip,rk3568-dwc-ahci
> +          - rockchip,rk3576-dwc-ahci
>            - rockchip,rk3588-dwc-ahci
>    required:
>      - compatible
> @@ -29,6 +30,7 @@ properties:
>      items:
>        - enum:
>            - rockchip,rk3568-dwc-ahci
> +          - rockchip,rk3576-dwc-ahci
>            - rockchip,rk3588-dwc-ahci
>        - const: snps,dwc-ahci
>  
> @@ -83,6 +85,7 @@ allOf:
>            contains:
>              enum:
>                - rockchip,rk3568-dwc-ahci
> +              - rockchip,rk3576-dwc-ahci
>      then:
>        properties:
>          clocks:
> 
> -- 
> 2.49.0
> 

Looks good to me:
Reviewed-by: Niklas Cassel <cassel@...nel.org>