linux-kernel - RE: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5370B284356960EBDE29A177EC842@BN9PR11MB5370.namprd11.prod.outlook.com>
Date: Fri, 25 Apr 2025 08:33:37 +0000
From: "Chang, Junxiao" <junxiao.chang@...el.com>
To: Jani Nikula <jani.nikula@...ux.intel.com>, "tomas.winkler@...el.com"
	<tomas.winkler@...el.com>, Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
	"Vivi, Rodrigo" <rodrigo.vivi@...el.com>, Tvrtko Ursulin
	<tursulin@...ulin.net>, David Airlie <airlied@...il.com>, Simona Vetter
	<simona@...ll.ch>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, "Clark
 Williams" <clrkwllms@...nel.org>, Steven Rostedt <rostedt@...dmis.org>,
	"Ceraolo Spurio, Daniele" <daniele.ceraolospurio@...el.com>, Vitaly Lubart
	<vitaly.lubart@...el.com>, "Usyskin, Alexander"
	<alexander.usyskin@...el.com>, "intel-gfx@...ts.freedesktop.org"
	<intel-gfx@...ts.freedesktop.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-rt-devel@...ts.linux.dev"
	<linux-rt-devel@...ts.linux.dev>
CC: "Zhou, Furong" <furong.zhou@...el.com>
Subject: RE: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq
 disabled context

On Fri, 25 Apr 2025, Jani Nikula <jani.nikula@...ux.intel.com> wrote:
>On Fri, 25 Apr 2025, Junxiao Chang <junxiao.chang@...el.com> wrote:
>> MEI GSC interrupt comes from i915. It has top half and bottom half.
>>
>> -	ret = generic_handle_irq(gt->gsc.intf[intf_id].irq);
>> +	/* It can be called in both irq context and in thread context */
>
>What is "It" in this case?
"It" means GSC interrupt handler, which is called via below API generic_handle_irq_safe. Sebastain has a comment on it as well that it doesn't deserves a comment. I could delete this comment.
>
>> +	ret = generic_handle_irq_safe(gt->gsc.intf[intf_id].irq);
>> +
>>  	if (ret)
>>  		gt_err_ratelimited(gt, "error handling GSC irq: %d\n", ret);  }
>
>--
>Jani Nikula, Intel