linux-kernel - Re: [PATCH v2] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f7a1675-1386-4ca5-8614-99b4847742ab@kernel.org>
Date: Fri, 25 Apr 2025 10:14:28 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Mikko Juhani Korhonen <mjkorhon@...il.com>
Cc: Niklas Cassel <cassel@...nel.org>, linux-ide@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard
 drives

On 4/25/25 05:43, Mikko Juhani Korhonen wrote:
> Make WDC WD20EFAX-68FB5N0 hard drive work again
> after regression in 6.9.0 when LPM was enabled,
> so disable it for this model
> 
> Signed-off-by: Mikko Korhonen <mjkorhon@...il.com>

I still cannot apply this. I get the errors:

error: corrupt patch at line 10
error: could not build fake ancestor

Your base-commit is Linus tag for Linux 6.14, which is not appropriate for new
patches. Please rebase this on libata for-6.15-fixes branch or Linus latest tree.

Also please properly format you commit message to use up to 72 characters per
line. And terminate your sentence with a period please.

> ---
> drivers/ata/libata-core.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index d956735e2a76..c429ba259548 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4208,6 +4208,11 @@ static const struct ata_dev_quirks_entry
> __ata_dev_quirks[] = {
>        { "WDC WD3000JD-*",             NULL,   ATA_QUIRK_WD_BROKEN_LPM },
>        { "WDC WD3200JD-*",             NULL,   ATA_QUIRK_WD_BROKEN_LPM },
> 
> +       /*
> +        * This specific WD SATA-3 model has problems with LPM.
> +        */
> +       { "WDC WD20EFAX-68FB5N0",       NULL,   ATA_QUIRK_NOLPM },
> +
>        /*
>         * This sata dom device goes on a walkabout when the ATA_LOG_DIRECTORY
>         * log page is accessed. Ensure we never ask for this log page with
> 
> base-commit: 38fec10eb60d687e30c8c6b5420d86e8149f7557
> --
> 2.47.2


-- 
Damien Le Moal
Western Digital Research