linux-kernel - Re: [PATCH v2 3/9] dt-bindings: qcom: geni-se: describe SA8255p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250425-grumpy-dainty-pillbug-be2145@kuoka>
Date: Fri, 25 Apr 2025 12:16:02 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Praveen Talari <quic_ptalari@...cinc.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Jiri Slaby <jirislaby@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>, Stephen Boyd <sboyd@...nel.org>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-serial@...r.kernel.org, devicetree@...r.kernel.org, linux-pm@...r.kernel.org, 
	psodagud@...cinc.com, djaggi@...cinc.com, quic_msavaliy@...cinc.com, 
	quic_vtanuku@...cinc.com, quic_arandive@...cinc.com, quic_mnaresh@...cinc.com, 
	quic_shazhuss@...cinc.com, Nikunj Kela <quic_nkela@...cinc.com>
Subject: Re: [PATCH v2 3/9] dt-bindings: qcom: geni-se: describe SA8255p

On Fri, Apr 18, 2025 at 08:42:29PM GMT, Praveen Talari wrote:
> +  "#size-cells":
> +    const: 2
> +
> +  ranges: true
> +
> +  iommus:
> +    maxItems: 1
> +
> +  dma-coherent: true
> +
> +required:

required: block goes after properties and patternproperties. I guess you
copied it from the existing geni binding, but new bindings can improve.

> +  - compatible
> +  - reg
> +  - "#address-cells"
> +  - "#size-cells"
> +  - ranges
> +
> +patternProperties:

Rest looks good so with this reordering:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof