linux-kernel - [PATCH] drm/i915/gt: Remove const from struct i915

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250426061357.work.749-kees@kernel.org>
Date: Fri, 25 Apr 2025 23:13:58 -0700
From: Kees Cook <kees@...nel.org>
To: Jani Nikula <jani.nikula@...ux.intel.com>
Cc: Kees Cook <kees@...nel.org>,
	Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Tvrtko Ursulin <tursulin@...ulin.net>,
	David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>,
	Matt Roper <matthew.d.roper@...el.com>,
	Gustavo Sousa <gustavo.sousa@...el.com>,
	Andi Shyti <andi.shyti@...ux.intel.com>,
	Lucas De Marchi <lucas.demarchi@...el.com>,
	intel-gfx@...ts.freedesktop.org,
	dri-devel@...ts.freedesktop.org,
	Gnattu OC <gnattuoc@...com>,
	Nitin Gote <nitin.r.gote@...el.com>,
	Ranu Maurya <ranu.maurya@...el.com>,
	Ville Syrjälä <ville.syrjala@...ux.intel.com>,
	Angus Chen <angus.chen@...el.com>,
	Juha-Pekka Heikkila <juhapekka.heikkila@...il.com>,
	Yu Jiaoliang <yujiaoliang@...o.com>,
	Dnyaneshwar Bhadane <dnyaneshwar.bhadane@...el.com>,
	linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: [PATCH] drm/i915/gt: Remove const from struct i915_wa list allocation

In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "struct i915_wa *". The returned type, while
technically matching, will be const qualified. As there is no general
way to remove const qualifiers, adjust the allocation type to match
the assignment.

Signed-off-by: Kees Cook <kees@...nel.org>
---
Cc: Jani Nikula <jani.nikula@...ux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@...el.com>
Cc: Tvrtko Ursulin <tursulin@...ulin.net>
Cc: David Airlie <airlied@...il.com>
Cc: Simona Vetter <simona@...ll.ch>
Cc: Matt Roper <matthew.d.roper@...el.com>
Cc: Gustavo Sousa <gustavo.sousa@...el.com>
Cc: Andi Shyti <andi.shyti@...ux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi@...el.com>
Cc: <intel-gfx@...ts.freedesktop.org>
Cc: <dri-devel@...ts.freedesktop.org>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 116683ebe074..b37e400f74e5 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -156,7 +156,7 @@ static void _wa_add(struct i915_wa_list *wal, const struct i915_wa *wa)
 	if (IS_ALIGNED(wal->count, grow)) { /* Either uninitialized or full. */
 		struct i915_wa *list;
 
-		list = kmalloc_array(ALIGN(wal->count + 1, grow), sizeof(*wa),
+		list = kmalloc_array(ALIGN(wal->count + 1, grow), sizeof(*list),
 				     GFP_KERNEL);
 		if (!list) {
 			drm_err(&i915->drm, "No space for workaround init!\n");
-- 
2.34.1