linux-kernel - [PATCH] media: iris: Cast iris_hfi_gen2_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250426061526.work.106-kees@kernel.org>
Date: Fri, 25 Apr 2025 23:15:27 -0700
From: Kees Cook <kees@...nel.org>
To: Vikash Garodia <quic_vgarodia@...cinc.com>
Cc: Kees Cook <kees@...nel.org>,
	Dikshita Agarwal <quic_dikshita@...cinc.com>,
	Abhinav Kumar <quic_abhinavk@...cinc.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	linux-media@...r.kernel.org,
	linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: [PATCH] media: iris: Cast iris_hfi_gen2_get_instance() allocation type

In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "struct iris_inst *", but the returned type is
"struct iris_inst_hfi_gen2 *". The allocation is intentionally larger as
the first member of struct iris_inst_hfi_gen2 is struct iris_inst, so
this is by design. Cast the allocation type to match the assignment.

Signed-off-by: Kees Cook <kees@...nel.org>
---
Cc: Vikash Garodia <quic_vgarodia@...cinc.com>
Cc: Dikshita Agarwal <quic_dikshita@...cinc.com>
Cc: Abhinav Kumar <quic_abhinavk@...cinc.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: <linux-media@...r.kernel.org>
Cc: <linux-arm-msm@...r.kernel.org>
---
 drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
index a908b41e2868..351820deb893 100644
--- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
+++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
@@ -953,5 +953,5 @@ void iris_hfi_gen2_command_ops_init(struct iris_core *core)
 
 struct iris_inst *iris_hfi_gen2_get_instance(void)
 {
-	return kzalloc(sizeof(struct iris_inst_hfi_gen2), GFP_KERNEL);
+	return (struct iris_inst *)kzalloc(sizeof(struct iris_inst_hfi_gen2), GFP_KERNEL);
 }
-- 
2.34.1