linux-kernel - [PATCH] soc: fsl: qbman: Remove const from portal->cgrs allocation type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250426062040.work.047-kees@kernel.org>
Date: Fri, 25 Apr 2025 23:20:41 -0700
From: Kees Cook <kees@...nel.org>
To: Christophe Leroy <christophe.leroy@...roup.eu>
Cc: Kees Cook <kees@...nel.org>,
	Sean Anderson <sean.anderson@...ux.dev>,
	Camelia Groza <camelia.groza@....com>,
	"David S. Miller" <davem@...emloft.net>,
	Vladimir Oltean <vladimir.oltean@....com>,
	"Dr. David Alan Gilbert" <linux@...blig.org>,
	linuxppc-dev@...ts.ozlabs.org,
	linux-arm-kernel@...ts.infradead.org,
	Michael Ellerman <mpe@...erman.id.au>,
	linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: [PATCH] soc: fsl: qbman: Remove const from portal->cgrs allocation type

In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "struct qman_cgrs *", but the returned type,
while technically matching, is const qualified. As there is no general
way to remove const qualifiers, adjust the allocation type to match
the assignment.

Signed-off-by: Kees Cook <kees@...nel.org>
---
Cc: Christophe Leroy <christophe.leroy@...roup.eu>
Cc: Sean Anderson <sean.anderson@...ux.dev>
Cc: Camelia Groza <camelia.groza@....com>
Cc: "David S. Miller" <davem@...emloft.net>
Cc: Vladimir Oltean <vladimir.oltean@....com>
Cc: "Dr. David Alan Gilbert" <linux@...blig.org>
Cc: <linuxppc-dev@...ts.ozlabs.org>
Cc: <linux-arm-kernel@...ts.infradead.org>
---
 drivers/soc/fsl/qbman/qman.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
index 4dc8aba33d9b..9be240999f87 100644
--- a/drivers/soc/fsl/qbman/qman.c
+++ b/drivers/soc/fsl/qbman/qman.c
@@ -1270,7 +1270,7 @@ static int qman_create_portal(struct qman_portal *portal,
 	qm_dqrr_set_ithresh(p, QMAN_PIRQ_DQRR_ITHRESH);
 	qm_mr_set_ithresh(p, QMAN_PIRQ_MR_ITHRESH);
 	qm_out(p, QM_REG_ITPR, QMAN_PIRQ_IPERIOD);
-	portal->cgrs = kmalloc_array(2, sizeof(*cgrs), GFP_KERNEL);
+	portal->cgrs = kmalloc_array(2, sizeof(*portal->cgrs), GFP_KERNEL);
 	if (!portal->cgrs)
 		goto fail_cgrs;
 	/* initial snapshot is no-depletion */
-- 
2.34.1