linux-kernel - Re: [PATCH net-next v12 1/9] netmem: add niov->type attribute to distinguish different net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a70511f2-70b2-4f48-94df-c55c179ce488@wanadoo.fr>
Date: Sat, 26 Apr 2025 08:31:10 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Mina Almasry <almasrymina@...gle.com>
Cc: andrew+netdev@...n.ch, asml.silence@...il.com, axboe@...nel.dk,
 corbet@....net, davem@...emloft.net, donald.hunter@...il.com,
 dsahern@...nel.org, dw@...idwei.uk, edumazet@...gle.com,
 eperezma@...hat.com, horms@...nel.org, hramamurthy@...gle.com,
 io-uring@...r.kernel.org, jasowang@...hat.com, jeroendb@...gle.com,
 jhs@...atatu.com, kuba@...nel.org, kuniyu@...zon.com, kvm@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, mst@...hat.com, ncardwell@...gle.com,
 netdev@...r.kernel.org, pabeni@...hat.com, pctammela@...atatu.com,
 sdf@...ichev.me, sgarzare@...hat.com, shuah@...nel.org, skhawaja@...gle.com,
 stefanha@...hat.com, victor@...atatu.com, virtualization@...ts.linux.dev,
 willemb@...gle.com, xuanzhuo@...ux.alibaba.com
Subject: Re: [PATCH net-next v12 1/9] netmem: add niov->type attribute to
 distinguish different net_iov types

Hi,

below a few nitpicks in case of a v13.


Le 25/04/2025 à 22:47, Mina Almasry a écrit :
> Later patches in the series adds TX net_iovs where there is no pp
> associated, so we can't rely on niov->pp->mp_ops to tell what is the
> type of the net_iov.
> 
> Add a type enum to the net_iov which tells us the net_iov type.
> 
> Signed-off-by: Mina Almasry <almasrymina@...gle.com>
> 
> ---

Nitpick: unneeded empty need line above ---?

...

> +enum net_iov_type {
> +	NET_IOV_DMABUF,
> +	NET_IOV_IOURING,
> +
> +	/* Force size to unsigned long to make the NET_IOV_ASSERTS below pass.
> +	 */
> +	NET_IOV_MAX = ULONG_MAX,

Nitpick: unneeded trailing , after such a terminator.

> +};

...

CJ