linux-kernel - Re: [PATCH v2] usb: dwc3: Abort suspend on soft disconnect failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250426004128.icwn74kz57swbkid@synopsys.com>
Date: Sat, 26 Apr 2025 00:41:32 +0000
From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To: Greg KH <gregkh@...uxfoundation.org>
CC: Kuen-Han Tsai <khtsai@...gle.com>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH v2] usb: dwc3: Abort suspend on soft disconnect failure

On Fri, Apr 25, 2025, Greg KH wrote:
> On Mon, Mar 24, 2025 at 11:17:55AM +0800, Kuen-Han Tsai wrote:
> > When dwc3_gadget_soft_disconnect() fails, dwc3_suspend_common() keeps
> > going with the suspend, resulting in a period where the power domain is
> > off, but the gadget driver remains connected.  Within this time frame,
> > invoking vbus_event_work() will cause an error as it attempts to access
> > DWC3 registers for endpoint disabling after the power domain has been
> > completely shut down.
> > 
> > Abort the suspend sequence when dwc3_gadget_suspend() cannot halt the
> > controller and proceeds with a soft connect.
> > 
> > Fixes: c8540870af4c ("usb: dwc3: gadget: Improve dwc3_gadget_suspend()
> > and dwc3_gadget_resume()")
> 
> Please do not line-wrap this type of thing.
> 
> thanks,
> 
> greg k-h

Did you check the latest change in v4:
https://lore.kernel.org/linux-usb/20250422221854.yl7ypzc4kkxbxw2a@synopsys.com/T/#m3ceb6dfb7b8a9681c456d410b9fcc1cc2869a447

I Acked that.

BR,
Thinh