| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAAhV-H6sQ4akmdraW_bd6gdr_Me9EYte-rbofumD3=04HA1MQA@mail.gmail.com>
Date: Sat, 26 Apr 2025 18:10:48 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc: loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] LoongArch: Handle fp, lsx, lasx and lbt assembly symbols
Applied, thanks.
Huacai
On Tue, Apr 15, 2025 at 5:19 PM Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:
>
> Like the other relevant symbols, export some fp, lsx, lasx and lbt
> assembly symbols and put the function declarations in header files
> rather than source files.
>
> While at it, use "asmlinkage" for the other existing C prototypes
> of assembly functions and also do not use the "extern" keyword with
> function declarations according to the document coding-style.rst.
>
> Cc: stable@...r.kernel.org # 6.6+
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
> arch/loongarch/include/asm/fpu.h | 38 ++++++++++++++++++--------------
> arch/loongarch/include/asm/lbt.h | 10 ++++++---
> arch/loongarch/kernel/fpu.S | 6 +++++
> arch/loongarch/kernel/lbt.S | 4 ++++
> arch/loongarch/kernel/signal.c | 21 ------------------
> 5 files changed, 39 insertions(+), 40 deletions(-)
>
> diff --git a/arch/loongarch/include/asm/fpu.h b/arch/loongarch/include/asm/fpu.h
> index 3177674228f8..23f5a4b9c32d 100644
> --- a/arch/loongarch/include/asm/fpu.h
> +++ b/arch/loongarch/include/asm/fpu.h
> @@ -22,22 +22,28 @@
> struct sigcontext;
>
> #define kernel_fpu_available() cpu_has_fpu
> -extern void kernel_fpu_begin(void);
> -extern void kernel_fpu_end(void);
> -
> -extern void _init_fpu(unsigned int);
> -extern void _save_fp(struct loongarch_fpu *);
> -extern void _restore_fp(struct loongarch_fpu *);
> -
> -extern void _save_lsx(struct loongarch_fpu *fpu);
> -extern void _restore_lsx(struct loongarch_fpu *fpu);
> -extern void _init_lsx_upper(void);
> -extern void _restore_lsx_upper(struct loongarch_fpu *fpu);
> -
> -extern void _save_lasx(struct loongarch_fpu *fpu);
> -extern void _restore_lasx(struct loongarch_fpu *fpu);
> -extern void _init_lasx_upper(void);
> -extern void _restore_lasx_upper(struct loongarch_fpu *fpu);
> +void kernel_fpu_begin(void);
> +void kernel_fpu_end(void);
> +
> +asmlinkage void _init_fpu(unsigned int);
> +asmlinkage void _save_fp(struct loongarch_fpu *);
> +asmlinkage void _restore_fp(struct loongarch_fpu *);
> +asmlinkage int _save_fp_context(void __user *fpregs, void __user *fcc, void __user *csr);
> +asmlinkage int _restore_fp_context(void __user *fpregs, void __user *fcc, void __user *csr);
> +
> +asmlinkage void _save_lsx(struct loongarch_fpu *fpu);
> +asmlinkage void _restore_lsx(struct loongarch_fpu *fpu);
> +asmlinkage void _init_lsx_upper(void);
> +asmlinkage void _restore_lsx_upper(struct loongarch_fpu *fpu);
> +asmlinkage int _save_lsx_context(void __user *fpregs, void __user *fcc, void __user *fcsr);
> +asmlinkage int _restore_lsx_context(void __user *fpregs, void __user *fcc, void __user *fcsr);
> +
> +asmlinkage void _save_lasx(struct loongarch_fpu *fpu);
> +asmlinkage void _restore_lasx(struct loongarch_fpu *fpu);
> +asmlinkage void _init_lasx_upper(void);
> +asmlinkage void _restore_lasx_upper(struct loongarch_fpu *fpu);
> +asmlinkage int _save_lasx_context(void __user *fpregs, void __user *fcc, void __user *fcsr);
> +asmlinkage int _restore_lasx_context(void __user *fpregs, void __user *fcc, void __user *fcsr);
>
> static inline void enable_lsx(void);
> static inline void disable_lsx(void);
> diff --git a/arch/loongarch/include/asm/lbt.h b/arch/loongarch/include/asm/lbt.h
> index e671978bf552..38566574e562 100644
> --- a/arch/loongarch/include/asm/lbt.h
> +++ b/arch/loongarch/include/asm/lbt.h
> @@ -12,9 +12,13 @@
> #include <asm/loongarch.h>
> #include <asm/processor.h>
>
> -extern void _init_lbt(void);
> -extern void _save_lbt(struct loongarch_lbt *);
> -extern void _restore_lbt(struct loongarch_lbt *);
> +asmlinkage void _init_lbt(void);
> +asmlinkage void _save_lbt(struct loongarch_lbt *);
> +asmlinkage void _restore_lbt(struct loongarch_lbt *);
> +asmlinkage int _save_lbt_context(void __user *regs, void __user *eflags);
> +asmlinkage int _restore_lbt_context(void __user *regs, void __user *eflags);
> +asmlinkage int _save_ftop_context(void __user *ftop);
> +asmlinkage int _restore_ftop_context(void __user *ftop);
>
> static inline int is_lbt_enabled(void)
> {
> diff --git a/arch/loongarch/kernel/fpu.S b/arch/loongarch/kernel/fpu.S
> index 6ab640101457..28caf416ae36 100644
> --- a/arch/loongarch/kernel/fpu.S
> +++ b/arch/loongarch/kernel/fpu.S
> @@ -458,6 +458,7 @@ SYM_FUNC_START(_save_fp_context)
> li.w a0, 0 # success
> jr ra
> SYM_FUNC_END(_save_fp_context)
> +EXPORT_SYMBOL_GPL(_save_fp_context)
>
> /*
> * a0: fpregs
> @@ -471,6 +472,7 @@ SYM_FUNC_START(_restore_fp_context)
> li.w a0, 0 # success
> jr ra
> SYM_FUNC_END(_restore_fp_context)
> +EXPORT_SYMBOL_GPL(_restore_fp_context)
>
> /*
> * a0: fpregs
> @@ -484,6 +486,7 @@ SYM_FUNC_START(_save_lsx_context)
> li.w a0, 0 # success
> jr ra
> SYM_FUNC_END(_save_lsx_context)
> +EXPORT_SYMBOL_GPL(_save_lsx_context)
>
> /*
> * a0: fpregs
> @@ -497,6 +500,7 @@ SYM_FUNC_START(_restore_lsx_context)
> li.w a0, 0 # success
> jr ra
> SYM_FUNC_END(_restore_lsx_context)
> +EXPORT_SYMBOL_GPL(_restore_lsx_context)
>
> /*
> * a0: fpregs
> @@ -510,6 +514,7 @@ SYM_FUNC_START(_save_lasx_context)
> li.w a0, 0 # success
> jr ra
> SYM_FUNC_END(_save_lasx_context)
> +EXPORT_SYMBOL_GPL(_save_lasx_context)
>
> /*
> * a0: fpregs
> @@ -523,6 +528,7 @@ SYM_FUNC_START(_restore_lasx_context)
> li.w a0, 0 # success
> jr ra
> SYM_FUNC_END(_restore_lasx_context)
> +EXPORT_SYMBOL_GPL(_restore_lasx_context)
>
> .L_fpu_fault:
> li.w a0, -EFAULT # failure
> diff --git a/arch/loongarch/kernel/lbt.S b/arch/loongarch/kernel/lbt.S
> index 001f061d226a..71678912d24c 100644
> --- a/arch/loongarch/kernel/lbt.S
> +++ b/arch/loongarch/kernel/lbt.S
> @@ -90,6 +90,7 @@ SYM_FUNC_START(_save_lbt_context)
> li.w a0, 0 # success
> jr ra
> SYM_FUNC_END(_save_lbt_context)
> +EXPORT_SYMBOL_GPL(_save_lbt_context)
>
> /*
> * a0: scr
> @@ -110,6 +111,7 @@ SYM_FUNC_START(_restore_lbt_context)
> li.w a0, 0 # success
> jr ra
> SYM_FUNC_END(_restore_lbt_context)
> +EXPORT_SYMBOL_GPL(_restore_lbt_context)
>
> /*
> * a0: ftop
> @@ -120,6 +122,7 @@ SYM_FUNC_START(_save_ftop_context)
> li.w a0, 0 # success
> jr ra
> SYM_FUNC_END(_save_ftop_context)
> +EXPORT_SYMBOL_GPL(_save_ftop_context)
>
> /*
> * a0: ftop
> @@ -150,6 +153,7 @@ SYM_FUNC_START(_restore_ftop_context)
> li.w a0, 0 # success
> jr ra
> SYM_FUNC_END(_restore_ftop_context)
> +EXPORT_SYMBOL_GPL(_restore_ftop_context)
>
> .L_lbt_fault:
> li.w a0, -EFAULT # failure
> diff --git a/arch/loongarch/kernel/signal.c b/arch/loongarch/kernel/signal.c
> index 7a555b600171..4740cb5b2388 100644
> --- a/arch/loongarch/kernel/signal.c
> +++ b/arch/loongarch/kernel/signal.c
> @@ -51,27 +51,6 @@
> #define lock_lbt_owner() ({ preempt_disable(); pagefault_disable(); })
> #define unlock_lbt_owner() ({ pagefault_enable(); preempt_enable(); })
>
> -/* Assembly functions to move context to/from the FPU */
> -extern asmlinkage int
> -_save_fp_context(void __user *fpregs, void __user *fcc, void __user *csr);
> -extern asmlinkage int
> -_restore_fp_context(void __user *fpregs, void __user *fcc, void __user *csr);
> -extern asmlinkage int
> -_save_lsx_context(void __user *fpregs, void __user *fcc, void __user *fcsr);
> -extern asmlinkage int
> -_restore_lsx_context(void __user *fpregs, void __user *fcc, void __user *fcsr);
> -extern asmlinkage int
> -_save_lasx_context(void __user *fpregs, void __user *fcc, void __user *fcsr);
> -extern asmlinkage int
> -_restore_lasx_context(void __user *fpregs, void __user *fcc, void __user *fcsr);
> -
> -#ifdef CONFIG_CPU_HAS_LBT
> -extern asmlinkage int _save_lbt_context(void __user *regs, void __user *eflags);
> -extern asmlinkage int _restore_lbt_context(void __user *regs, void __user *eflags);
> -extern asmlinkage int _save_ftop_context(void __user *ftop);
> -extern asmlinkage int _restore_ftop_context(void __user *ftop);
> -#endif
> -
> struct rt_sigframe {
> struct siginfo rs_info;
> struct ucontext rs_uctx;
> --
> 2.42.0
>
>
Powered by blists - more mailing lists