linux-kernel - kernel/cgroup/dmem.c:21: warning: Cannot understand * @ref: References keeping the region alive.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202504261939.1yj5iNwS-lkp@intel.com>
Date: Sat, 26 Apr 2025 19:48:38 +0800
From: kernel test robot <lkp@...el.com>
To: Maarten Lankhorst <dev@...khorst.se>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Maxime Ripard <mripard@...nel.org>,
	Friedrich Vock <friedrich.vock@....de>
Subject: kernel/cgroup/dmem.c:21: warning: Cannot understand          * @ref:
 References keeping the region alive.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   02ddfb981de88a2c15621115dd7be2431252c568
commit: b168ed458ddecc176f3b9a1f4bcd83d7a4541c14 kernel/cgroup: Add "dmem" memory accounting cgroup
date:   4 months ago
config: riscv-randconfig-001-20250426 (https://download.01.org/0day-ci/archive/20250426/202504261939.1yj5iNwS-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250426/202504261939.1yj5iNwS-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504261939.1yj5iNwS-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/cgroup/dmem.c:21: warning: Cannot understand          * @ref: References keeping the region alive.
    on line 21 - I thought it was a doc line
>> kernel/cgroup/dmem.c:30: warning: Cannot understand          * @region_node: Linked into &dmem_cgroup_regions list.
    on line 30 - I thought it was a doc line
>> kernel/cgroup/dmem.c:36: warning: Cannot understand          * @pools: List of pools linked to this region.
    on line 36 - I thought it was a doc line
>> kernel/cgroup/dmem.c:48: warning: Cannot understand          * @unregistered: Whether the region is unregistered by its caller.
    on line 48 - I thought it was a doc line
   kernel/cgroup/dmem.c:300: warning: Excess function parameter 'dev' description in 'dmem_cgroup_state_evict_valuable'
   kernel/cgroup/dmem.c:300: warning: Excess function parameter 'index' description in 'dmem_cgroup_state_evict_valuable'
   kernel/cgroup/dmem.c:635: warning: Function parameter or struct member 'region' not described in 'dmem_cgroup_try_charge'
   kernel/cgroup/dmem.c:635: warning: Excess function parameter 'dev' description in 'dmem_cgroup_try_charge'


vim +21 kernel/cgroup/dmem.c

    18	
    19	struct dmem_cgroup_region {
    20		/**
  > 21		 * @ref: References keeping the region alive.
    22		 * Keeps the region reference alive after a succesful RCU lookup.
    23		 */
    24		struct kref ref;
    25	
    26		/** @rcu: RCU head for freeing */
    27		struct rcu_head rcu;
    28	
    29		/**
  > 30		 * @region_node: Linked into &dmem_cgroup_regions list.
    31		 * Protected by RCU and global spinlock.
    32		 */
    33		struct list_head region_node;
    34	
    35		/**
  > 36		 * @pools: List of pools linked to this region.
    37		 * Protected by global spinlock only
    38		 */
    39		struct list_head pools;
    40	
    41		/** @size: Size of region, in bytes */
    42		u64 size;
    43	
    44		/** @name: Name describing the node, set by dmem_cgroup_register_region */
    45		char *name;
    46	
    47		/**
  > 48		 * @unregistered: Whether the region is unregistered by its caller.
    49		 * No new pools should be added to the region afterwards.
    50		 */
    51		bool unregistered;
    52	};
    53	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki