linux-kernel - Re: [PATCH v3 4/4] arm64: dts: qcom: Add support for X1-based Asus Zenbook A14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMcHhXreXNFr5vD3rMKZygqfvP2y7=t1OUr8d37O-zRc-quc5g@mail.gmail.com>
Date: Sat, 26 Apr 2025 14:13:53 +0200
From: Aleksandrs Vinarskis <alex.vinarskis@...il.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Abel Vesa <abel.vesa@...aro.org>, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org, 
	Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, maud_spierings@...mail.com, 
	dmitry.baryshkov@....qualcomm.com
Subject: Re: [PATCH v3 4/4] arm64: dts: qcom: Add support for X1-based Asus
 Zenbook A14

On Sat, 26 Apr 2025 at 12:19, Konrad Dybcio
<konrad.dybcio@....qualcomm.com> wrote:
>
> On 4/17/25 1:20 AM, Aleksandrs Vinarskis wrote:
> > Initial support for Asus Zenbook A14. Particular moddel exists
> > in X1-26-100, X1P-42-100 (UX3407QA) and X1E-78-100 (UX3407RA).
> >
> > Mostly similar to other X1-based laptops. Notable differences are:
> > * Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA
> >   and Qualcomm FastConnect 7800 on UX3407RA
> > * USB Type-C retimers are Parade PS8833, appear to behave identical
> >   to Parade PS8830
> > * gpio90 is TZ protected
> >
> > Working:
> > * Keyboard
> > * Touchpad
> > * NVME
> > * Lid switch
> > * Camera LED
> > * eDP (FHD OLED, SDC420D) with brightness control
> > * Bluetooth, WiFi (WCN6855)
> > * USB Type-A port
> > * USB Type-C ports in USB2/USB3/DP (both orientations)
> > * aDSP/cDPS firmware loading, battery info
> > * Sleep/suspend, nothing visibly broken on resume
> >
> > Out of scope of this series:
> > * Audio (Speakers/microphones/headphone jack)
> > * Camera (OmniVision OV02C10)
> > * HDMI (Parade PS185HDM)
> > * EC
> >
> > Add dtsi and create two configurations for UX3407QA, UX3407RA.
> > Tested on UX3407QA with X1-26-100.
> >
> > Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@...il.com>
> > ---
>
> [...]
>
> > +     /* Left-side display-adjacent port, PS8833 */
>
> nit: The mention of PS8833 in the comment is rather uneventful given it
> says so right below it as well

Good point, will remove.

>
> > +     typec-mux@8 {
> > +             compatible = "parade,ps8833", "parade,ps8830";
>
> [...]
>
> > +&uart14 {
> > +     status = "okay";
> > +
> > +     bluetooth {
> > +             /* TODO: add pwrseq once validated */
> > +             compatible = "qcom,wcn7850-bt";
> > +
> > +             max-speed = <3000000>;
> > +     };
> > +};
>
> Drop it for now, the dt checker is angry about partial definitions

Hmm, but then this variant won't have bluetooth working at all...
Will drop, let's hope someone from the community has x1e variant to
test pwrseq for wnc7850 for a follow up patch soon.

Thanks,

Alex

>
> I think it looks ok otherwise
>
> Konrad