linux-kernel - Re: [PATCH v2 5/8] net: ethernet: sis900: Use pure PCI devres API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <559370be-a366-4754-8baf-3a4b332be025@brownhat.org>
Date: Sat, 26 Apr 2025 14:39:40 +0200
From: Daniele Venzano <venza@...wnhat.org>
To: Philipp Stanner <phasta@...nel.org>, Sunil Goutham
 <sgoutham@...vell.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Geetha sowjanya <gakula@...vell.com>, Subbaraya Sundeep
 <sbhatta@...vell.com>, hariprasad <hkelam@...vell.com>,
 Bharat Bhushan <bbhushan2@...vell.com>,
 Taras Chornyi <taras.chornyi@...ision.eu>,
 Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, Helge Deller <deller@....de>,
 Simon Horman <horms@...nel.org>, Jacob Keller <jacob.e.keller@...el.com>,
 Ingo Molnar <mingo@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Al Viro <viro@...iv.linux.org.uk>, Shannon Nelson <shannon.nelson@....com>,
 Sabrina Dubroca <sd@...asysnail.net>
Cc: linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-parisc@...r.kernel.org
Subject: Re: [PATCH v2 5/8] net: ethernet: sis900: Use pure PCI devres API

On 25/04/2025 10:57, Philipp Stanner wrote:
> The currently used function pci_request_regions() is one of the
> problematic "hybrid devres" PCI functions, which are sometimes managed
> through devres, and sometimes not (depending on whether
> pci_enable_device() or pcim_enable_device() has been called before).
>
> The PCI subsystem wants to remove this behavior and, therefore, needs to
> port all users to functions that don't have this problem.
>
> Replace pci_request_regions() with pcim_request_all_regions().
>
> Signed-off-by: Philipp Stanner <phasta@...nel.org>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
Acked-by: Daniele Venzano <venza@...wnhat.org>
> ---
>   drivers/net/ethernet/sis/sis900.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
> index 332cbd725900..df869f82cae8 100644
> --- a/drivers/net/ethernet/sis/sis900.c
> +++ b/drivers/net/ethernet/sis/sis900.c
> @@ -468,7 +468,7 @@ static int sis900_probe(struct pci_dev *pci_dev,
>   	SET_NETDEV_DEV(net_dev, &pci_dev->dev);
>   
>   	/* We do a request_region() to register /proc/ioports info. */
> -	ret = pci_request_regions(pci_dev, "sis900");
> +	ret = pcim_request_all_regions(pci_dev, "sis900");
>   	if (ret)
>   		goto err_out;
>