lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202504262154.sBmNTrcB-lkp@intel.com>
Date: Sat, 26 Apr 2025 21:32:51 +0800
From: kernel test robot <lkp@...el.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Mark Brown <broonie@...nel.org>
Subject: sound/soc/qcom/sdw.c:93: warning: cannot understand function
 prototype: 'ret = sdw_enable_stream(sruntime); '

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   02ddfb981de88a2c15621115dd7be2431252c568
commit: db7e59e6a39a4d3d54ca8197c796557e6d480b0d ASoC: qcom: sc7280: Fix missing Soundwire runtime stream alloc
date:   6 months ago
config: sh-randconfig-002-20250426 (https://download.01.org/0day-ci/archive/20250426/202504262154.sBmNTrcB-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250426/202504262154.sBmNTrcB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504262154.sBmNTrcB-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> sound/soc/qcom/sdw.c:93: warning: cannot understand function prototype: 'ret = sdw_enable_stream(sruntime); '

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for GET_FREE_REGION
   Depends on [n]: SPARSEMEM [=n]
   Selected by [y]:
   - RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y]


vim +93 sound/soc/qcom/sdw.c

d32bac9cb09cce Krzysztof Kozlowski 2023-11-28   52  
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   53  int qcom_snd_sdw_prepare(struct snd_pcm_substream *substream,
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   54  			 struct sdw_stream_runtime *sruntime,
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   55  			 bool *stream_prepared)
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   56  {
77678a25d1ecf7 Krzysztof Kozlowski 2024-04-30   57  	struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
9b1a2dfa8a00ff Kuninori Morimoto   2023-09-11   58  	struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   59  	int ret;
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   60  
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   61  	if (!sruntime)
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   62  		return 0;
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   63  
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   64  	switch (cpu_dai->id) {
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   65  	case WSA_CODEC_DMA_RX_0:
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   66  	case WSA_CODEC_DMA_RX_1:
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   67  	case RX_CODEC_DMA_RX_0:
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   68  	case RX_CODEC_DMA_RX_1:
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   69  	case TX_CODEC_DMA_TX_0:
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   70  	case TX_CODEC_DMA_TX_1:
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   71  	case TX_CODEC_DMA_TX_2:
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   72  	case TX_CODEC_DMA_TX_3:
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   73  		break;
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   74  	default:
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   75  		return 0;
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   76  	}
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   77  
e2e53088635924 Srinivas Kandagatla 2023-03-23   78  	if (*stream_prepared)
e2e53088635924 Srinivas Kandagatla 2023-03-23   79  		return 0;
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   80  
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   81  	ret = sdw_prepare_stream(sruntime);
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   82  	if (ret)
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   83  		return ret;
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   84  
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   85  	/**
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   86  	 * NOTE: there is a strict hw requirement about the ordering of port
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   87  	 * enables and actual WSA881x PA enable. PA enable should only happen
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   88  	 * after soundwire ports are enabled if not DC on the line is
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   89  	 * accumulated resulting in Click/Pop Noise
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   90  	 * PA enable/mute are handled as part of codec DAPM and digital mute.
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   91  	 */
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   92  
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31  @93  	ret = sdw_enable_stream(sruntime);
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   94  	if (ret) {
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   95  		sdw_deprepare_stream(sruntime);
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   96  		return ret;
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   97  	}
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   98  	*stream_prepared  = true;
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31   99  
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31  100  	return ret;
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31  101  }
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31  102  EXPORT_SYMBOL_GPL(qcom_snd_sdw_prepare);
0cbf1ecd8c4801 Stephan Gerhold     2022-12-31  103  

:::::: The code at line 93 was first introduced by commit
:::::: 0cbf1ecd8c4801ec7566231491f7ad9cec31098b ASoC: qcom: Fix building APQ8016 machine driver without SOUNDWIRE

:::::: TO: Stephan Gerhold <stephan@...hold.net>
:::::: CC: Mark Brown <broonie@...nel.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ