linux-kernel - drivers/staging/media/av7110/av7110.c:162: warning: cannot understand function prototype: '} else if (av7110_init_analog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <202504262127.FkkWHzfs-lkp@intel.com>
Date: Sat, 26 Apr 2025 21:54:01 +0800
From: kernel test robot <lkp@...el.com>
To: Stefan Herdler <herdler@...fuerspam.de>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Hans Verkuil <hverkuil@...all.nl>
Subject: drivers/staging/media/av7110/av7110.c:162: warning: cannot
 understand function prototype: '} else if (av7110_init_analog_module(av7110)
 == 0) '

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   02ddfb981de88a2c15621115dd7be2431252c568
commit: 3c08dc38e3cf018a74c64e75cebcc803d973196c media: av7110: coding style fixes: comparsations
date:   11 months ago
config: x86_64-buildonly-randconfig-001-20250426 (https://download.01.org/0day-ci/archive/20250426/202504262127.FkkWHzfs-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250426/202504262127.FkkWHzfs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504262127.FkkWHzfs-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/staging/media/av7110/av7110.c:162: warning: cannot understand function prototype: '} else if (av7110_init_analog_module(av7110) == 0) '


vim +162 drivers/staging/media/av7110/av7110.c

   112	
   113	static void init_av7110_av(struct av7110 *av7110)
   114	{
   115		int ret;
   116		struct saa7146_dev *dev = av7110->dev;
   117	
   118		/* set internal volume control to maximum */
   119		av7110->adac_type = DVB_ADAC_TI;
   120		ret = av7110_set_volume(av7110, av7110->mixer.volume_left, av7110->mixer.volume_right);
   121		if (ret < 0)
   122			printk("dvb-ttpci:cannot set internal volume to maximum:%d\n",ret);
   123	
   124		ret = av7110_fw_cmd(av7110, COMTYPE_ENCODER, SetMonitorType,
   125				    1, (u16)av7110->display_ar);
   126		if (ret < 0)
   127			printk("dvb-ttpci: unable to set aspect ratio\n");
   128		ret = av7110_fw_cmd(av7110, COMTYPE_ENCODER, SetPanScanType,
   129				    1, av7110->display_panscan);
   130		if (ret < 0)
   131			printk("dvb-ttpci: unable to set pan scan\n");
   132	
   133		ret = av7110_fw_cmd(av7110, COMTYPE_ENCODER, SetWSSConfig, 2, 2, wss_cfg_4_3);
   134		if (ret < 0)
   135			printk("dvb-ttpci: unable to configure 4:3 wss\n");
   136		ret = av7110_fw_cmd(av7110, COMTYPE_ENCODER, SetWSSConfig, 2, 3, wss_cfg_16_9);
   137		if (ret < 0)
   138			printk("dvb-ttpci: unable to configure 16:9 wss\n");
   139	
   140		ret = av7710_set_video_mode(av7110, vidmode);
   141		if (ret < 0)
   142			printk("dvb-ttpci:cannot set video mode:%d\n",ret);
   143	
   144		/* handle different card types */
   145		/* remaining inits according to card and frontend type */
   146		av7110->analog_tuner_flags = 0;
   147		av7110->current_input = 0;
   148		if (dev->pci->subsystem_vendor == 0x13c2 && dev->pci->subsystem_device == 0x000a)
   149			av7110_fw_cmd(av7110, COMTYPE_AUDIODAC, ADSwitch, 1, 0); // SPDIF on
   150		if (i2c_writereg(av7110, 0x20, 0x00, 0x00) == 1) {
   151			printk ("dvb-ttpci: Crystal audio DAC @ card %d detected\n",
   152				av7110->dvb_adapter.num);
   153			av7110->adac_type = DVB_ADAC_CRYSTAL;
   154			i2c_writereg(av7110, 0x20, 0x01, 0xd2);
   155			i2c_writereg(av7110, 0x20, 0x02, 0x49);
   156			i2c_writereg(av7110, 0x20, 0x03, 0x00);
   157			i2c_writereg(av7110, 0x20, 0x04, 0x00);
   158	
   159			/**
   160			 * some special handling for the Siemens DVB-C cards...
   161			 */
 > 162		} else if (av7110_init_analog_module(av7110) == 0) {
   163			/* done. */
   164		} else if (dev->pci->subsystem_vendor == 0x110a) {
   165			printk("dvb-ttpci: DVB-C w/o analog module @ card %d detected\n",
   166				av7110->dvb_adapter.num);
   167			av7110->adac_type = DVB_ADAC_NONE;
   168		} else {
   169			av7110->adac_type = adac;
   170			printk("dvb-ttpci: adac type set to %d @ card %d\n",
   171				av7110->adac_type, av7110->dvb_adapter.num);
   172		}
   173	
   174		if (av7110->adac_type == DVB_ADAC_NONE || av7110->adac_type == DVB_ADAC_MSP34x0) {
   175			// switch DVB SCART on
   176			ret = av7110_fw_cmd(av7110, COMTYPE_AUDIODAC, MainSwitch, 1, 0);
   177			if (ret < 0)
   178				printk("dvb-ttpci:cannot switch on SCART(Main):%d\n",ret);
   179			ret = av7110_fw_cmd(av7110, COMTYPE_AUDIODAC, ADSwitch, 1, 1);
   180			if (ret < 0)
   181				printk("dvb-ttpci:cannot switch on SCART(AD):%d\n",ret);
   182			if (rgb_on &&
   183			    ((av7110->dev->pci->subsystem_vendor == 0x110a) ||
   184			     (av7110->dev->pci->subsystem_vendor == 0x13c2)) &&
   185			     (av7110->dev->pci->subsystem_device == 0x0000)) {
   186				saa7146_setgpio(dev, 1, SAA7146_GPIO_OUTHI); // RGB on, SCART pin 16
   187				//saa7146_setgpio(dev, 3, SAA7146_GPIO_OUTLO); // SCARTpin 8
   188			}
   189		}
   190	
   191		if (dev->pci->subsystem_vendor == 0x13c2 && dev->pci->subsystem_device == 0x000e)
   192			av7110_fw_cmd(av7110, COMTYPE_AUDIODAC, SpdifSwitch, 1, 0); // SPDIF on
   193	
   194		ret = av7110_set_volume(av7110, av7110->mixer.volume_left, av7110->mixer.volume_right);
   195		if (ret < 0)
   196			printk("dvb-ttpci:cannot set volume :%d\n",ret);
   197	}
   198	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki