linux-kernel - Re: [PATCH v7 2/2] iio: adc: add support for Nuvoton NCT7201

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250426151738.43f0d25a@jic23-huawei>
Date: Sat, 26 Apr 2025 15:17:38 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Eason Yang <j2anfernee@...il.com>, lars@...afoo.de, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, dlechner@...libre.com,
 nuno.sa@...log.com, javier.carrasco.cruz@...il.com, gstols@...libre.com,
 olivier.moysan@...s.st.com, alisadariana@...il.com, tgamblin@...libre.com,
 antoniu.miclaus@...log.com, eblanc@...libre.com,
 joao.goncalves@...adex.com, ramona.gradinariu@...log.com,
 marcelo.schmitt@...log.com, matteomartelli3@...il.com,
 chanh@...amperecomputing.com, KWLIU@...oton.com, yhyang2@...oton.com,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 2/2] iio: adc: add support for Nuvoton NCT7201


> 
> > +	/* Enable Channel */
> > +	if (chip->num_vin_channels <= 8) {
> > +		err = regmap_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE,
> > +				   GENMASK(chip->num_vin_channels - 1, 0));  
> 
> > +		if (err)
> > +			return dev_err_probe(dev, err, "Failed to enable channel\n");  
> 
> This...
> 
> > +	} else {
> > +		err = regmap_bulk_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE,
> > +					&data, sizeof(data));  
> 
> > +		if (err)
> > +			return dev_err_probe(dev2, err, "Failed to enable channel\n");  
> 
> ...and this are identical, deduplicate by moving outside of if-else.
> 
Not worth the dev vs dev2 distinction.  They are ultimately the same device so
just use dev for both.

> > +	}  
> 
>