linux-kernel - Re: [PATCH] bcachefs: Fix unit-value within btree_bounce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c32cu4mrdeln3kovzgehwjccfx2qpfh7evsgiug6ckshfux76q@ms6mab54ivy5>
Date: Sat, 26 Apr 2025 11:03:08 -0400
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: I Hsin Cheng <richard120310@...il.com>
Cc: syzbot+549710bad9c798e25b15@...kaller.appspotmail.com, 
	bfoster@...hat.com, linux-bcachefs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	davem@...emloft.net, herbert@...dor.apana.org.au, linux-crypto@...r.kernel.org, 
	syzkaller-bugs@...glegroups.com, skhan@...uxfoundation.org, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] bcachefs: Fix unit-value within btree_bounce_alloc()

On Sat, Apr 26, 2025 at 12:53:49AM +0800, I Hsin Cheng wrote:
> On Wed, Apr 23, 2025 at 12:45:20PM -0400, Kent Overstreet wrote:
> > On Thu, Apr 24, 2025 at 12:37:18AM +0800, I Hsin Cheng wrote:
> > > Use "kvzalloc()" instead of "kvmalloc()" in btree_bounce_alloc() to
> > > prevent uninit-value issue.
> > > 
> > > Reported-by: syzbot+549710bad9c798e25b15@...kaller.appspotmail.com
> > > Closes: https://syzkaller.appspot.com/bug?extid=549710bad9c798e25b15
> > > Fixes: cb6fc943b650 ("bcachefs: kill kvpmalloc()")
> > > Signed-off-by: I Hsin Cheng <richard120310@...il.com>
> > > ---
> > > syzbot reported an uninit-value issue. [1]
> > > 
> > > Though the uninit value was detected in the context of crc32_body(), the
> > > memory was actually allocated in "btree_bounce_alloc()". Use
> > > "kvzalloc()" to allocate the memory can solve the issue, and I've tested
> > > against syzbot. [2]
> > > 
> > > If there're any further tests needed to be performed, please let me
> > > know. I'll be more than happy to assist you with that, thanks !
> > 
> > See Documentation/filesystems/bcachefs/SubmittingPatches.
> >
> 
> Sure ! Thanks for the info.
> 
> > And this isn't the correct fix - the correct fix is already in Linus's
> > tree.
> 
> Ahh ok, may I ask for the commit hash or title so I can learn from it ?

9c3a2c9b471a bcachefs: Disable asm memcpys when kmsan enabled