linux-kernel - Re: [PATCH] usr/include: openrisc: don't HDRTEST bpf_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aA0GfU513267ndkY@antec>
Date: Sat, 26 Apr 2025 17:14:53 +0100
From: Stafford Horne <shorne@...il.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Masahiro Yamada <masahiroy@...nel.org>,
	Jonas Bonn <jonas@...thpole.se>,
	Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
	linux-openrisc@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] usr/include: openrisc: don't HDRTEST bpf_perf_event.h

On Sat, Apr 26, 2025 at 08:45:38AM -0700, Randy Dunlap wrote:
> 
> 
> On 4/25/25 11:00 PM, Stafford Horne wrote:
> > Hi Randy,
> > 
> > On Fri, Apr 25, 2025 at 08:08:15PM -0700, Randy Dunlap wrote:
> >> Since openrisc does not support PERF_EVENTS, omit the HDRTEST of
> >> bpf_perf_event.h for arch/openrisc/.
> >>
> >> Fixes a build error:
> >> usr/include/linux/bpf_perf_event.h:14:28: error: field 'regs' has incomplete type
> > 
> > This looks ok to me, but do you have any pointer of how to reproduce this?
> > 
> 
> All I did was 'make allmodconfig' or 'make allyesconfig'. Either of them cause
> this error.

Thanks, I was just now able to figure this out after some more reading of
usr/include/Makefile.  As long as I have CONFIG_UAPI_HEADER_TEST enabled the
HDRTEST's will run and I could produce this.

I suppose this should go via the Yamada-san's make tree. So:

Acked-by: Stafford Horne <shorne@...il.com>

> > -Stafford
> > 
> >> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> >> Cc: Masahiro Yamada <masahiroy@...nel.org>
> >> Cc: Jonas Bonn <jonas@...thpole.se>
> >> Cc: Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>
> >> Cc: Stafford Horne <shorne@...il.com>
> >> Cc: linux-openrisc@...r.kernel.org
> >> Cc: linux-kbuild@...r.kernel.org
> >> ---
> >>  usr/include/Makefile |    4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> --- linux-next-20250424.orig/usr/include/Makefile
> >> +++ linux-next-20250424/usr/include/Makefile
> >> @@ -59,6 +59,10 @@ ifeq ($(SRCARCH),arc)
> >>  no-header-test += linux/bpf_perf_event.h
> >>  endif
> >>  
> >> +ifeq ($(SRCARCH),openrisc)
> >> +no-header-test += linux/bpf_perf_event.h
> >> +endif
> >> +
> >>  ifeq ($(SRCARCH),powerpc)
> >>  no-header-test += linux/bpf_perf_event.h
> >>  endif
> 
> -- 
> ~Randy
>