linux-kernel - Re: [PATCH] iov_iter: Use iov_offset for length calculation in iov_iter_aligned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ad12473-6eb4-4cd4-a3de-be5255d84a44@kernel.dk>
Date: Fri, 25 Apr 2025 18:04:02 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Nitesh Shetty <nj.shetty@...sung.com>,
 Alexander Viro <viro@...iv.linux.org.uk>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: gost.dev@...sung.com, nitheshshetty@...il.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iov_iter: Use iov_offset for length calculation in
 iov_iter_aligned_bvec

On 4/15/25 12:14 PM, Nitesh Shetty wrote:
> If iov_offset is non-zero, then we need to consider iov_offset in length
> calculation, otherwise we might pass smaller IOs such as 512 bytes
> with 256 bytes offset.

As Andrew points out, would be nicer with a (much) better commit
message. Your current reply has a lot of the stuff that should go in
there, including a Fixes tag. With that done:

Reviewed-by: Jens Axboe <axboe@...nel.dk>

-- 
Jens Axboe