linux-kernel - Re: [PATCHv3 net] bonding: assign random address if device address is same as bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250425190419.273eb34b@kernel.org>
Date: Fri, 25 Apr 2025 19:04:19 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jay Vosburgh <jv@...sburgh.net>
Cc: Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Nikolay
 Aleksandrov <razor@...ckwall.org>, Simon Horman <horms@...nel.org>, Cosmin
 Ratiu <cratiu@...dia.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 net] bonding: assign random address if device address
 is same as bond

On Thu, 24 Apr 2025 16:44:52 -0700 Jay Vosburgh wrote:
> 	The code flow is a little clunky in the "if (situation one) else
> if (situation two) else goto skip_mac_set" bit, but I don't really have
> a better suggestion that isn't clunky in some other way.
> 
> 	This implementation does keep the already complicated failover
> logic from becoming more complicated for this corner case.

Any thoughts on whether we should route this as a fix or as a -next
improvement? The commit under Fixes is almost old enough to drink.