| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aA0pDUDQViCA1hwi@gmail.com>
Date: Sat, 26 Apr 2025 20:42:21 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
linux-trace-kernel@...r.kernel.org,
Masami Hiramatsu <mhiramat@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Peter Zijlstra <peterz@...radead.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
Kees Cook <kees@...nel.org>, bpf@...r.kernel.org,
Tejun Heo <tj@...nel.org>, Julia Lawall <Julia.Lawall@...ia.fr>,
Nicolas Palix <nicolas.palix@...g.fr>, cocci@...ia.fr,
"H. Peter Anvin" <hpa@...or.com>,
Thomas Gleixner <tglx@...utronix.de>
Subject: [PATCH] sched/core: Introduce task_*() helpers for PF_ flags
* Steven Rostedt <rostedt@...dmis.org> wrote:
> On Fri, 25 Apr 2025 16:14:49 -0700
> Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> > Seems sensible. Please consider renaming PF_KTHREAD in order to break
> > missed conversion sites.
>
> It's not wrong to use the thread. I just find using these helper
> functions a bit easier to review code. There's also some places that
> have special tests where it can't use the flag:
>
> kernel/sched/core.c: if (!curr->mm || (curr->flags & (PF_EXITING | PF_KTHREAD)) ||
> kernel/sched/fair.c: if (!curr->mm || (curr->flags & (PF_EXITING | PF_KTHREAD)) || work->next != work)
> kernel/trace/bpf_trace.c: current->flags & (PF_KTHREAD | PF_EXITING)))
> kernel/trace/bpf_trace.c: if (unlikely(task->flags & (PF_KTHREAD | PF_EXITING)))
>
> Maybe we can have a: is_user_exiting_or_kthread() ?
No, we don't need is_user_exiting_or_kthread(). At all. Ever. In this
universe. Or in any alternative universes. We don't even need
is_user_exiting_or_kthread() in horror fiction novels written for
kernel developers: there's really a limit to the level of horror that
people are able to accept. Sheesh ...
This:
if (task_kthread(task) || task_exiting(task))
...
is a perfectly fine and readable C expression.
There's also *zero* reason for the whole is_*() complication your
methods introduce. There's no need for 'is_' if we put a proper noun as
a prefix before these methods, such as task_*(), and it also nicely
organizes the namespace!
Let's not complicate trivial use of C logical operators unnecessarily,
and let's not suck at namespaces more than we need to, 'kay?
( What's next, are we going to redefine 'if (x)' statements???
... wait a minute ... ;-)
The attached patch does the sane thing and introduces the following
helpers for PF_ flags:
/*
* Helpers for PF_ flags:
*/
#define task_vcpu(task) ((task)->flags & PF_VCPU)
#define task_idle(task) ((task)->flags & PF_IDLE)
#define task_exiting(task) ((task)->flags & PF_EXITING)
#define task_postcoredump(task) ((task)->flags & PF_POSTCOREDUMP)
#define task_io_worker(task) ((task)->flags & PF_IO_WORKER)
#define task_wq_worker(task) ((task)->flags & PF_WQ_WORKER)
#define task_forknoexec(task) ((task)->flags & PF_FORKNOEXEC)
#define task_mce_process(task) ((task)->flags & PF_MCE_PROCESS)
#define task_superpriv(task) ((task)->flags & PF_SUPERPRIV)
#define task_dumpcore(task) ((task)->flags & PF_DUMPCORE)
#define task_signaled(task) ((task)->flags & PF_SIGNALED)
#define task_memalloc(task) ((task)->flags & PF_MEMALLOC)
#define task_nproc_exceeded(task) ((task)->flags & PF_NPROC_EXCEEDED)
#define task_used_math(task) ((task)->flags & PF_USED_MATH)
#define task_user_worker(task) ((task)->flags & PF_USER_WORKER)
#define task_nofreeze(task) ((task)->flags & PF_NOFREEZE)
#define task_kcompactd(task) ((task)->flags & PF_KCOMPACTD)
#define task_kswapd(task) ((task)->flags & PF_KSWAPD)
#define task_memalloc_nofs(task) ((task)->flags & PF_MEMALLOC_NOFS)
#define task_memalloc_noio(task) ((task)->flags & PF_MEMALLOC_NOIO)
#define task_local_throttle(task) ((task)->flags & PF_LOCAL_THROTTLE)
#define task_kthread(task) ((task)->flags & PF_KTHREAD)
#define task_randomize(task) ((task)->flags & PF_RANDOMIZE)
#define task_no_setaffinity(task) ((task)->flags & PF_NO_SETAFFINITY)
#define task_mce_early(task) ((task)->flags & PF_MCE_EARLY)
#define task_memalloc_pin(task) ((task)->flags & PF_MEMALLOC_PIN)
#define task_block_ts(task) ((task)->flags & PF_BLOCK_TS)
#define task_suspend_task(task) ((task)->flags & PF_SUSPEND_TASK)
These are easy names, precise lower-case variants of the PF_ flag
names: if you know the PF flag's name, you know the helper's name as
well.
And no, we don't need separate helpers for !task_kthread() et al: the C
logical negation unary operator is perfectly readable when placed
before a function call or a macro invocation, and a competent Linux
kernel developer is expected to recognize it on sight:
if (!task_kthread(task))
...
Let's not infantilize the kernel source...
You can find this patch in my tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git WIP.sched/core
Note that I plan to add a few more patches as well, while we are
touching this area:
- tsk_used_math() is now overlapping and should be consolidated a bit.
And the used_math() indirection should go away as well.
- I'll add conversion patches as well, at minimum for the top 10 flags
that cover 90%+ of the PF_ flag usage:
nr of uses | flag
-------------------------
7 | PF_USED_MATH
8 | PF_USER_WORKER
10 PF_NOFREEZE
15 PF_WQ_WORKER
18 PF_NO_SETAFFINITY
18 PF_VCPU
24 PF_RANDOMIZE
30 PF_MEMALLOC
73 PF_EXITING
92 PF_KTHREAD
[ Or maybe for all of them - see below wrt. set_task_*(). ]
- PF_ goes for 'per-process flag' and as such it is a total misnomer,
proudly misrepresented in <linux/sched.h>:
/*
* Per process flags
*/
#define PF_VCPU 0x00000001 /* I'm a virtual CPU */
#define PF_IDLE 0x00000002 /* I am an IDLE thread */
Yeah, no: the PF_ flags haven't been "per process" ever since we
introduced threading 25 years ago...
Renaming just for that causes churn, but it becomes easier once we
have the conversion patches for helpers for explicit uses of PF_
flags.
- We might want to add set_task_*() helpers as well, to totally
encapsulate PF_ uses. Maybe. I dislike how close it is to the
existing set_tsk*() methods that manipulate TIF_ flags. The
dichotomy between the TIF_ and PF_ space isn't really sensible these
days I think on a conceptual level - although merging them is
probably not practical due to possibly running out of easy 64-bit
word width.
I'll send out a full series if there's no better suggestions for the
general approach.
Thanks,
Ingo
============================>
From: Ingo Molnar <mingo@...nel.org>
Date: Sat, 26 Apr 2025 20:00:22 +0200
Subject: [PATCH] sched/core: Introduce task_*() helpers for PF_ flags
Add straightforward PF_ task flag helpers:
if (!(task->flags & PF_KTHREAD))
...
|
\|/
V
if (!task_kthread(task))
...
( Fortunately there's no namespace collision for any of the new
methods introduced. )
Suggested-by: Steven Rostedt <rostedt@...dmis.org>
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
include/linux/sched.h | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index f96ac1982893..ef5a2e98dd9e 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1747,6 +1747,38 @@ extern struct pid *cad_pid;
#define PF__HOLE__40000000 0x40000000
#define PF_SUSPEND_TASK 0x80000000 /* This thread called freeze_processes() and should not be frozen */
+/*
+ * Helpers for PF_ flags:
+ */
+#define task_vcpu(task) ((task)->flags & PF_VCPU)
+#define task_idle(task) ((task)->flags & PF_IDLE)
+#define task_exiting(task) ((task)->flags & PF_EXITING)
+#define task_postcoredump(task) ((task)->flags & PF_POSTCOREDUMP)
+#define task_io_worker(task) ((task)->flags & PF_IO_WORKER)
+#define task_wq_worker(task) ((task)->flags & PF_WQ_WORKER)
+#define task_forknoexec(task) ((task)->flags & PF_FORKNOEXEC)
+#define task_mce_process(task) ((task)->flags & PF_MCE_PROCESS)
+#define task_superpriv(task) ((task)->flags & PF_SUPERPRIV)
+#define task_dumpcore(task) ((task)->flags & PF_DUMPCORE)
+#define task_signaled(task) ((task)->flags & PF_SIGNALED)
+#define task_memalloc(task) ((task)->flags & PF_MEMALLOC)
+#define task_nproc_exceeded(task) ((task)->flags & PF_NPROC_EXCEEDED)
+#define task_used_math(task) ((task)->flags & PF_USED_MATH)
+#define task_user_worker(task) ((task)->flags & PF_USER_WORKER)
+#define task_nofreeze(task) ((task)->flags & PF_NOFREEZE)
+#define task_kcompactd(task) ((task)->flags & PF_KCOMPACTD)
+#define task_kswapd(task) ((task)->flags & PF_KSWAPD)
+#define task_memalloc_nofs(task) ((task)->flags & PF_MEMALLOC_NOFS)
+#define task_memalloc_noio(task) ((task)->flags & PF_MEMALLOC_NOIO)
+#define task_local_throttle(task) ((task)->flags & PF_LOCAL_THROTTLE)
+#define task_kthread(task) ((task)->flags & PF_KTHREAD)
+#define task_randomize(task) ((task)->flags & PF_RANDOMIZE)
+#define task_no_setaffinity(task) ((task)->flags & PF_NO_SETAFFINITY)
+#define task_mce_early(task) ((task)->flags & PF_MCE_EARLY)
+#define task_memalloc_pin(task) ((task)->flags & PF_MEMALLOC_PIN)
+#define task_block_ts(task) ((task)->flags & PF_BLOCK_TS)
+#define task_suspend_task(task) ((task)->flags & PF_SUSPEND_TASK)
+
/*
* Only the _current_ task can read/write to tsk->flags, but other
* tasks can access tsk->flags in readonly mode for example
Powered by blists - more mailing lists